Modify

Opened 3 years ago

Closed 14 months ago

#17072 closed defect (fixed)

[PATCH] The image viewer for Geotagged images should not clear between pictures

Reported by: taylor.smock Owned by: simon04
Priority: normal Milestone: 21.04
Component: Core image mapping Version: latest
Keywords: Cc:

Description

Expected behavior:
Screen does not flash between images

Current behavior (JOSM 14507):
Screen flashes "Loading <PICTURE>"

While the current behavior is OK when looking at very few images, when video mapping is used (https://wiki.openstreetmap.org/wiki/Video_mapping), it can be hard on the eyes when quickly flipping through images.

Possible alternatives:
1) Leave currently loaded image up until the next image is ready, displaying a "Loading <picture>" below or in place of the current metadata, possibly ignoring further input (for the image viewer) until the image is ready.
2) Preload the next <n> images to avoid loading from disk

Attachments (2)

17072.patch (610 bytes) - added by taylor.smock 2 years ago.
Don't clear set image to null when the next entry is not null
17072.1.patch (7.1 KB) - added by taylor.smock 15 months ago.
Add option to have background of error text show up (disabled by default -- can be hard on the eyes), properly show loading/error text

Download all attachments as: .zip

Change History (13)

comment:1 Changed 3 years ago by Don-vip

2) is addressed by #4172

comment:2 in reply to:  1 Changed 3 years ago by zlavergne

Replying to Don-vip:

2) is addressed by #4172

Has this had any headway? It looks like it's been inactive for 5 years.

Changed 2 years ago by taylor.smock

Attachment: 17072.patch added

Don't clear set image to null when the next entry is not null

comment:3 Changed 2 years ago by taylor.smock

So I finally got around to looking into this more, and it turns out we (a) always set the new image to null when a new image is set and then (b) immediately call repaint(). This patch only sets the image to null if the new ImageEntry is null.

So far, in my usage, it seems to be working well.

comment:4 Changed 2 years ago by taylor.smock

Summary: The image viewer for Geotagged images should not clear between pictures[WIP PATCH] The image viewer for Geotagged images should not clear between pictures

Changed 15 months ago by taylor.smock

Attachment: 17072.1.patch added

Add option to have background of error text show up (disabled by default -- can be hard on the eyes), properly show loading/error text

comment:6 Changed 15 months ago by taylor.smock

Summary: [WIP PATCH] The image viewer for Geotagged images should not clear between pictures[PATCH] The image viewer for Geotagged images should not clear between pictures

What the new patch does:

  • Does not set the image to null when the new ImageEntry (in setImage) is not null. This avoids clearing the screen (thus causing a white flash, since the next image is almost always immediately loaded).
  • Adds a new setting geoimage.message.error.background, which defaults to false to avoid a flashing white section of the screen. This affects how the error messages are displayed.
  • Adds a field to keep track of the old ImageEntry so that an appropriate message can be shown (does oldImageEntry == imageEntry? If so, we have loaded the image and don't have to show a loading message)
  • Draw the image first and the messages second (otherwise, the image would overwrite the error text)

comment:7 Changed 14 months ago by taylor.smock

Patch ping

comment:8 Changed 14 months ago by Don-vip

Milestone: 21.04

comment:9 Changed 14 months ago by taylor.smock

Patch ping.

comment:10 Changed 14 months ago by simon04

Owner: changed from team to simon04
Status: newassigned

comment:11 Changed 14 months ago by simon04

Resolution: fixed
Status: assignedclosed

In 17783/josm:

fix #17072 - Geotagged images viewer should not clear between pictures (patch by taylor.smock)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.