[Patch] Refactor the GeoImageLayer and related to use a Data class with a selection listener

[francois2]

My goal is to add the ability to select multiple images in the geoimagelayer to be able to move them with the photoadjust plugin.

I started the work by moving the handle of the data to a new class ImageData with a selection listener. Most of the methods of the GeoImageLayer have been moved. The ImageViewerDialog now listen for the selection change. This remove the coupling with the GeoImageLayer.

I also fixed a few bugs with buttons on the ImageViewDialog

[Don-vip]

Wow impressive, thanks! Some feedback below:

1. Can you please explain this change?

   @@ -493,7 +544,7 @@ public final class ImageViewerDialog extends ToggleDialog implements LayerChange
         * @since 6392
         */
        public static GeoImageLayer getCurrentLayer() {
   -        return getInstance().currentLayer;
   +        return null;
        }
    
        /**
   

2. Did you run ant checkstyle pmd to check the code style too?

[francois2]

Replying to Don-vip:

Wow impressive, thanks! Some feedback below:

Thanks!

1. Can you please explain this change?

   @@ -493,7 +544,7 @@ public final class ImageViewerDialog extends ToggleDialog implements LayerChange
         * @since 6392
         */
        public static GeoImageLayer getCurrentLayer() {
   -        return getInstance().currentLayer;
   +        return null;
        }
    
        /**
   

I forgot to remove it. I fixed that as well as removing some unused methods.

2. Did you run ant checkstyle pmd to check the code style too?

Nope. I fixed a few warnings.

[francois2]

New patch

[francois2]

I'm working on a new patch to allow multiple image selection. In the meantime, I saw that the current patch broke the photoadjust plugin.

There is multiple options:

1. wait until all patch are ready
2. wait until I provide the patch to fix the photoadjust plugin

I prefer the 2. What do you think ?

[Don-vip]

2 is ok :)

[francois2]

Patch v3

[francois2]

Patch v3.1

[francois2]

The patch on the photo adjust plugin

[francois2]

I updated the patch to add new methods to update the image and a new callback when the image(s)change.

It introduced a performance problem in the photoadjust plugin, as on each move the image dialog was refreshed. I fixed it by checking the osd update and doing nothing most of the time.