Modify

Opened 20 months ago

Closed 10 days ago

Last modified 10 days ago

#17026 closed enhancement (fixed)

[Patch] Validator should not complain about reg_name without name

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.06
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Create way with tag reg_name=Hansalinie and maybe highway=motorway
  2. Run validator

What is the expected result?

no warning

What happens instead?

warning "alternative name without name"

Please provide any additional information below. Attach a screenshot if possible.

I am not sure if this tag is correct, it is used for many members of relation 5611236. I remember that the road was called Hansalinie when I was young, but I did not here that name for a long time.
Attached patch changes the rule to treat reg_name like old_name.

Build-Date:2018-11-25 06:31:38
Revision:14442
Is-Local-Build:true

Identification: JOSM/1.5 (14442 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 1547 MB / 3641 MB (297 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:53205, -ea, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34535)
+ apache-commons (34506)
+ buildings_tools (34724)
+ download_along (34503)
+ ejml (34389)
+ geotools (34513)
+ importvec (34520)
+ jaxb (34506)
+ jts (34524)
+ merge-overlap (34664)
+ o5m (34405)
+ opendata (34698)
+ pbf (34576)
+ poly (34546)
+ reverter (34552)
+ undelete (34568)
+ utilsplugin2 (34506)

Last errors/warnings:
- W: Test 'Unconnected highways' completed in 0 ms
- W: Test 'Unconnected natural lands and landuses' completed in 0 ms
- W: Test 'Unconnected power ways' completed in 0 ms
- W: Test 'Untagged and unconnected nodes' completed in 1 ms
- W: Test 'Untagged, empty and one node ways' completed in 0 ms
- W: Test 'Way connected to Area' completed in 0 ms
- W: Test 'Wrongly Ordered Ways' completed in 1 ms
- W: Failed to locate resource '/README'.
- W: Failed to locate resource '/CONTRIBUTION'.
- W: Failed to locate resource '/LICENSE'.

Attachments (1)

reg_name.patch (741 bytes) - added by GerdP 20 months ago.

Download all attachments as: .zip

Change History (7)

Changed 20 months ago by GerdP

Attachment: reg_name.patch added

comment:1 Changed 20 months ago by GerdP

One more thought: Maybe the test would perform faster if the exceptions where added to the regex instead? I am sure that is possible but I am not very fit with regex syntax.

comment:2 Changed 20 months ago by naoliv

Isn't Hansalinie a name, like in https://www.openstreetmap.org/way/381210437 ?
Or the name is Bundesautobahn 1 with reg_name = Hansalinie? https://de.wikipedia.org/wiki/Bundesautobahn_1

comment:3 Changed 20 months ago by GerdP

No idea, I always call it by its ref: A 1. Maybe something I should ask in the German forum first?

comment:5 Changed 10 days ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16713/josm:

fix #17026 - Don't warn about reg_name without name (similar to loc_name)

comment:6 Changed 10 days ago by Klumbumbus

Milestone: 20.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.