Modify

Opened 6 months ago

Closed 3 months ago

Last modified 3 months ago

#17020 closed defect (fixed)

Update style for leisure=track

Reported by: naoliv Owned by: team
Priority: normal Milestone: 19.02
Component: Internal mappaint style Version:
Keywords: Cc:

Description

It seems that since october leisure=track aren't interpreted as area anymore on the default style, giving us this:

https://i.imgur.com/lQK4QUC.png

But JOSM still renders them as areas:

https://i.imgur.com/BZMskqD.png

Probably JOSM should have the style updated to reflect this (ie, leisure=track + area=yes, render as area; leisure=track without area=yes, render as a way)

Attachments (1)

test.osm (5.1 KB) - added by naoliv 6 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 months ago by naoliv

Possible patch:

  • styles/standard/elemstyles.mapcss

    diff --git a/styles/standard/elemstyles.mapcss b/styles/standard/elemstyles.mapcss
    index ba7b9645f..34033eee2 100644
    a b node[leisure=water_park] { 
    17051705    icon-image: "presets/leisure/water_park.svg";
    17061706    set icon_z17;
    17071707}
    1708 area[leisure=track][!area?!]:closed {
     1708relation[leisure=track][!area?!]:closed,
     1709way[leisure=track][area?]:closed {
    17091710    fill-color: leisuretrack#d4f4b9;
    17101711}
     1712relation[leisure=track][area?!],
    17111713way[leisure=track] {
    17121714    width: 2;
    17131715    color: leisuretrack#d4f4b9;

Example test attached.

Changed 6 months ago by naoliv

Attachment: test.osm added

comment:2 Changed 3 months ago by Klumbumbus

Milestone: 19.02

comment:3 Changed 3 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14808/josm:

fix #17020 - display leisure=track as line only (without fill color) by default. If area=yes is added or if it's a multipolygon, display the fill color. Warn about area=no on multipolygons (error level).

comment:4 Changed 3 months ago by Klumbumbus

I hope I didn't miss a case.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.