Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16894 closed defect (wontfix)

Unspecific "service=yes is unspecific. Please replace 'yes' by a specific value." for shop=mobile_phone

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. encounter shop=mobile_phone, service=yes - https://www.openstreetmap.org/node/5937373885
  2. run validator

What is the expected result?

I know based on validator message how problem should be fixed (I accept that I may need to survey it)

What happens instead?

I get unspecific "Please replace 'yes' by a specific value." Service dropdown has mix of values like "alley", "driveway" etc so it is not helpful.

Please provide any additional information below. Attach a screenshot if possible.

I think that service=yes in this case is perfectly fine.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-26 01:55:07 +0200 (Fri, 26 Oct 2018)
Build-Date:2018-10-26 01:32:58
Revision:14366
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14366 en) Linux Ubuntu 16.04.5 LTS
Memory Usage: 668 MB / 869 MB (219 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34535)
+ buildings_tools (34572)
+ continuosDownload (82)
+ imagery_offset_db (34641)
+ measurement (34529)
+ reverter (34552)
+ todo (30306)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- E: Bad Request - org.openstreetmap.josm.gui.widgets.HtmlPanel[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]
- W: javax.script.ScriptException: ReferenceError: "console" is not defined in <eval> at line number 44. Cause: jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "console" is not defined
- E: javax.script.ScriptException: ReferenceError: "console" is not defined in <eval> at line number 44. Cause: jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "console" is not defined
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out

Attachments (0)

Change History (6)

comment:1 by mkoniecz, 7 years ago

Summary: Unspecific "service=yes is unspecific. Please replace 'yes' by a specific value. (1)"Unspecific "service=yes is unspecific. Please replace 'yes' by a specific value." for shop=mobile_phone

comment:2 by naoliv, 7 years ago

With service=yes you mean that it also repairs phones, sells, etc?

comment:3 by mkoniecz, 7 years ago

Yes, the indended meaning was that in addition to selling phones and related products some repair of mobile devices and help with mobile devices is offered.

comment:4 by naoliv, 7 years ago

https://wiki.openstreetmap.org/wiki/Tag:shop%3Dmobile_phone cites mobile_phone:repair=*
Maybe this (or other similar key) is what you need here?

At least for me, service=yes in fact seems to be nonspecific and should be warned :-)

comment:5 by Klumbumbus, 7 years ago

Resolution: wontfix
Status: newclosed

https://www.openstreetmap.org/node/5937373885

Thats the only node worldwide tagged with shop=mobile_phone, service=yes
No need for a validator rule change imho.

comment:6 by mkoniecz, 7 years ago

Thats the only node worldwide tagged with shop=mobile_phone, service=yes

Now 0 again :)

Thanks for a tagging help!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.