Remove getopt

[michael2402]

Drop the gnu.getopt package

This is a really old C library and we would clean up our code a lot by using our own parser. This would also allow us to add common options (e.g. logging level, ...) to a common place.

[michael2402]

While doing this I would like to drop some posix stuff that probably nobody uses (and that might be more confusing than useful). E.g.:

josm -W foo is the same as josm --foo (we did not activate this)

There are some other tweaks that are only activated if the system property gnu.posixly_correct is set (ignoring -- after short option, ...) that I will drop. An error message (e.g. missing argument) is displayed instead.

We will allow arguments to be specified before options.
So the format would be like this:

josm -o --option argument1 --with-arg=test --with-arg test -- argument2 argument3

-- is optional to mark all following arguments as non-properties to allow them to start with a -- (good for scripting)

I don't think we will break any scripts using this because only few people are aware of the tweaks you could have done using posix getopts and fewer people used them.

[Don-vip]

I didn't even know about this strange syntax. No objections to drop it.

[michael2402]

The patch is complete, just needs testing (I have not really played around with the program arguments and tested the two CLI applications)

TODO for sometime during this week.

[michael2402]

... missed the test file

[michael2402]

In 14415/josm:

See #16866: Drop getopt, use own option parser.

[michael2402]

Getopt is removed, let me know if there are any issues with the new parsing mechanism. I tested a few variants and added a full unit test for the parser logic, but there might be some cases that I missed.

[michael2402]

In 14416/josm:

See #16866: Fix errorprone warning.

[Don-vip]

In 14417/josm:

see #16866 - drop/update remaining files

[Don-vip]

In 14419/josm:

see #16866 : fix PMD warnings