Modify

Opened 4 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#16853 closed defect (fixed)

When objects to upload are > 10k, JOSM uploads in chunks of 1 object only

Reported by: naoliv Owned by: team
Priority: normal Milestone: 18.10
Component: Core Version:
Keywords: upload changeset chunk Cc:

Description (last modified by naoliv)

I already saw 2 persons complaining about how long JOSM is taking to upload their changes and also saying that "I forgot to configure JOSM, because it's uploading only object at a time", which I found odd.

Trying to investigate using a clean JOSM home it's possible to see that, by default, JOSM uploads all changes in only one request (as it should):

https://i.imgur.com/1TZ6bKh.png

But if we have more than 10k objects to upload, JOSM changes to 1 object per request:

https://i.imgur.com/FyJNtG8.png
https://i.imgur.com/a9HXZXq.png

And now the user will have a nice patience test waiting for the upload.

I see 2 issues here:

  • If JOSM can't upload all objects in only one request (which is perfectly understandable when the number of objects is high), then it should use a saner chunk value (personally I like 100, but it could be 1000 maybe)
  • It should not silently change the upload strategy/values like this

JOSM:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-17 17:25:28 +0200 (Wed, 17 Oct 2018)
Revision:14344
Build-Date:2018-10-18 01:32:42
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14344 en) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 215 MB / 1970 MB (73 MB allocated, but free)
Java version: 10.0.2+13-Debian-1, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-10-jre:amd64-10.0.2+13-1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21
VM arguments: [-Djosm.home=<josm.pref>, -Dawt.useSystemAAFontSettings=on]
Program arguments: [--language=en]

Attachments (0)

Change History (6)

comment:1 Changed 4 weeks ago by naoliv

Description: modified (diff)

comment:2 Changed 4 weeks ago by Don-vip

Keywords: upload changeset chunk added
Milestone: 18.10

I see only the first point as an issue. It's not silent at all, this is written in plain text with a warning symbol.

comment:3 Changed 4 weeks ago by Don-vip

Can you please attach your test file?

comment:4 Changed 4 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 14345/josm:

fix #16853 - increase osm-server.upload-strategy.chunk-size default value from 1 to 1000

comment:5 Changed 4 weeks ago by stoecker

Why not choose the maximum number?

comment:6 Changed 4 weeks ago by Don-vip

It was completely arbitrary :) It would work too.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.