Modify

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#16841 closed enhancement (fixed)

[PATCH] MergeLayerActionTest, DownloadWmsAlongTrackActionTest: fix for non-headless mode by properly mocking dialogs

Reported by: ris Owned by: team
Priority: minor Milestone: 18.10
Component: Unit tests Version:
Keywords: headless Cc:

Description

This includes the addition of a small interface addition to the dialog mockers: an act() hook method to provide a place to take mutating actions on the dialog when shown. See comments for further details.

https://github.com/openstreetmap/josm/pull/40

Patches based on r14323

Change History (11)

comment:1 Changed 7 months ago by Don-vip

Milestone: 18.10

comment:2 Changed 7 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14332/josm:

fix #16841 - MergeLayerActionTest, DownloadWmsAlongTrackActionTest: fix for non-headless mode by properly mocking dialogs (patch by ris)

comment:3 Changed 7 months ago by Don-vip

In 14336/josm:

see #16841 - checkstyle

comment:4 Changed 7 months ago by Don-vip

We should add Checkstyle to travis too :)

comment:5 Changed 7 months ago by ris

I guess so - I think I removed it because we were getting worryingly near the 1h limit at one point.

comment:6 Changed 7 months ago by ris

Actually at the moment ant checkstyle is refusing to run for me on my local machine - "Unable to process files:" (goes on to list ~2000 files). Go figure.

comment:7 Changed 7 months ago by Don-vip

Works at least for me on Windows 10 and on JOSM server on Ubuntu. What's your environment?

comment:8 Changed 7 months ago by ris

Linux - I might try with a clean checkout.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.