Modify ↓
#16841 closed enhancement (fixed)
[PATCH] MergeLayerActionTest, DownloadWmsAlongTrackActionTest: fix for non-headless mode by properly mocking dialogs
| Reported by: | ris | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | 18.10 |
| Component: | Unit tests | Version: | |
| Keywords: | headless | Cc: |
Description
This includes the addition of a small interface addition to the dialog mockers: an act() hook method to provide a place to take mutating actions on the dialog when shown. See comments for further details.
https://github.com/openstreetmap/josm/pull/40
Patches based on r14323
Attachments (3)
Change History (11)
by , 7 years ago
| Attachment: | v1-0001-tests-dialog-mockers-add-act-hook-method-to-all-o.patch added |
|---|
by , 7 years ago
| Attachment: | v1-0002-ExtendedDialogMocker-add-getContent-utility-metho.patch added |
|---|
by , 7 years ago
| Attachment: | v1-0003-MergeLayerActionTest-DownloadWmsAlongTrackActionT.patch added |
|---|
comment:1 by , 7 years ago
| Milestone: | → 18.10 |
|---|
comment:2 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 7 years ago
I guess so - I think I removed it because we were getting worryingly near the 1h limit at one point.
comment:6 by , 7 years ago
Actually at the moment ant checkstyle is refusing to run for me on my local machine - "Unable to process files:" (goes on to list ~2000 files). Go figure.
comment:7 by , 7 years ago
Works at least for me on Windows 10 and on JOSM server on Ubuntu. What's your environment?
Note:
See TracTickets
for help on using tickets.
In 14332/josm: