Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#16838 closed defect (fixed)

Nested svg elements are displayed wrongly

Reported by: AdVerburg Owned by: team
Priority: normal Milestone: 18.10
Component: Core Version:
Keywords: template_report svg nested offset Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Configure paint style ​http://duinoord.home.xs4all.nl/OSM/JOSM/NL_traffic_signs/Styles_Traffic_signs-style.mapcss
  2. Load this node into JOSM: node 4236434683
  3. Look at the rendered icon.

What is the expected result?

an image with the two elements visible

What happens instead?

the image components are displayed stacked together.

Please provide any additional information below. Attach a screenshot if possible.

screenshot traffic_sign=NL:C03,OB54

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-01 23:59:36 +0200 (Mon, 01 Oct 2018)
Revision:14289
Build-Date:2018-10-01 22:08:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14289 en_GB) Linux openSUSE Tumbleweed
Memory Usage: 487 MB / 1974 MB (200 MB allocated, but free)
Java version: 11+28-suse-1.1-x8664, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: java-11-openjdk:x86_64-11.0.0.0
Dataset consistency test: No problems found

Plugins:
+ Mapillary (v1.5.17)
+ OpeningHoursEditor (34535)
+ PicLayer (34544)
+ SeaChart (34237)
+ SeaMapEditor (34589)
+ apache-commons (34506)
+ apache-http (34632)
+ ejml (34389)
+ geojson (87)
+ geotools (34513)
+ graphview (34576)
+ jna (34633)
+ jts (34524)
+ measurement (34529)
+ opendata (34675)
+ reverter (34552)
+ turnrestrictions (34643)
+ utilsplugin2 (34506)

Tagging presets:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Presets_Hafen.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenSeaMap_bridge&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ <josm.pref>/Beacons.xml
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Presets/NL-Fiets.zip

Map paint styles:
+ https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT1_MapCSS.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
+ http://duinoord.home.xs4all.nl/OSM/JOSM/NL_traffic_signs/Styles_Traffic_signs-style.mapcss
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Styles/Road_Extended_JOSM_style.zip

Validator rules:
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss

Last errors/warnings:
- W: Unkown setting type: integer
- W: Unkown setting type: integer
- W: Unkown setting type: integer
- W: No configuration settings found.  Using hardcoded default values for all pools.

This traffic_sign is just an example, the problem is with all combined traffic_signs.
A frequent used system of one pole with multiple signs attached.
With a single sign there is no display problem.
In LibreOffice-Draw, Firefox, Brave etc. the image is displayed correctly.

file in the cache, (how JOSM the traffic_sign, in miniature, is supposed to display

Attachments (3)

Screenshot_20181013_203821.png (2.1 KB) - added by AdVerburg 2 years ago.
screenshot traffic_sign=NL:C03,OB54
mirror_https___duinoord.xs4all.nl_OSM_JOSM_NL_traffic_signs_svgbuilder_merge.svg.php_signs_NL_C03_NL_OB54.svg (6.8 KB) - added by AdVerburg 2 years ago.
file in the cache, (how JOSM the traffic_sign, in miniature, is supposed to display
svg_bug.png (7.9 KB) - added by Don-vip 2 years ago.

Download all attachments as: .zip

Change History (18)

Changed 2 years ago by AdVerburg

screenshot traffic_sign=NL:C03,OB54

Changed 2 years ago by AdVerburg

file in the cache, (how JOSM the traffic_sign, in miniature, is supposed to display

comment:1 Changed 2 years ago by AdVerburg

Description: modified (diff)

comment:2 Changed 2 years ago by Don-vip

Description: modified (diff)

comment:3 Changed 2 years ago by Don-vip

Description: modified (diff)
Keywords: svg added

Changed 2 years ago by Don-vip

Attachment: svg_bug.png added

comment:4 Changed 2 years ago by Don-vip

Indeed svgSalamander output is:


comment:5 Changed 2 years ago by Don-vip

In 14328/josm:

see #14319, see #16838 - update to svgSalamander 1.1.2

comment:6 Changed 2 years ago by Don-vip

In 14331/josm:

see #14319, see #16838 - fix regressions introduced in svgSalamander 1.1.2

see https://github.com/blackears/svgSalamander/issues/29

comment:7 Changed 2 years ago by Don-vip

Display is still broken with svgSalamander 1.1.2 (patched)

comment:9 Changed 2 years ago by Don-vip

Keywords: nested offset added
Milestone: 18.10
Summary: svg displays wronglyNested svg elements are displayed wrongly

comment:10 Changed 2 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 14333/josm:

fix #16838 - render nested svg elements properly

see https://github.com/blackears/svgSalamander/issues/31

comment:11 Changed 2 years ago by michael2402

Do we have a list of changes we applied to svgSalamander that are not in the original version (their master and their 1.1.2)?

Last edited 2 years ago by michael2402 (previous) (diff)

comment:12 Changed 2 years ago by Don-vip

There is not, I send patches upstream every time.

comment:13 Changed 2 years ago by Don-vip

In 14334/josm:

see #14319, see #16838 - svgSalamander fix for CVE-2017-5617 was incomplete

See https://github.com/blackears/svgSalamander/issues/11

comment:14 Changed 2 years ago by AdVerburg

Thanks, I'm very pleased.

comment:15 Changed 2 years ago by Don-vip

In 14361/josm:

see #14319, see #16838 - fix another NPE / regression from svgSalamander 1.1.2 (causing unit test failure in DXF plugin)

see https://github.com/blackears/svgSalamander/pull/34

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.