Modify

Opened 8 months ago

Closed 8 months ago

#16831 closed enhancement (fixed)

Create road route - 'apply preset' does nothing

Reported by: kennykb Owned by: team
Priority: normal Milestone: 18.10
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Select a group of ways that you want to be in a 'route=road' relation
  2. Select Presets->Relations->Routes->Road Route
  3. Fill in the dialog and click 'Apply Preset'

What is the expected result?

Either create a new relation, or warn that the requested 'apply preset' will do nothing.

What happens instead?

'Apply Preset' does nothing. No relation gets created ('New Relation' does that, of course!), Everything that was typed in the dialog is lost.

Please provide any additional information below. Attach a screenshot if possible.

It's pretty annoying, because 'Apply Preset' is the normal action for virtually all other presets, and it's kind of a reflex to click it.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-01 23:59:36 +0200 (Mon, 01 Oct 2018)
Revision:14289
Build-Date:2018-10-01 22:08:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14289 en) Linux Ubuntu 18.04.1 LTS
Memory Usage: 7072 MB / 8012 MB (1698 MB allocated, but free)
Java version: 10.0.2+13-Ubuntu-1ubuntu0.18.04.2, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-10.0.2+13-1ubuntu0.18.04.2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-20ubuntu0.1
Dataset consistency test: No problems found

Plugins:
+ ImportImagePlugin (34576)
+ OpeningHoursEditor (34535)
+ PicLayer (34544)
+ apache-commons (34506)
+ ejml (34389)
+ geotools (34513)
+ jts (34524)
+ log4j (34527)
+ opendata (34675)
+ reverter (34552)
+ utilsplugin2 (34506)

Tagging presets:
+ ${HOME}/josm/stateParkPreset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/TigerReviewedNo&zip=1

Last errors/warnings:
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: connect timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>

Attachments (0)

Change History (3)

comment:1 Changed 8 months ago by stoecker

Milestone: 18.10

Probably we should disable/grey out the "Apply preset" when 0 objects will be the target?

comment:2 Changed 8 months ago by anonymous

Either that, or at least throw a warning and allow the user to return to the dialog, whichever is easier.

The objectionable behaviour is losing the data entry and having the user possibly fail to notice that no relation was created.

comment:3 Changed 8 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14319/josm:

fix #16831 - disable "Apply preset" button when no matching object is selected

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.