Opened 7 years ago
Closed 7 years ago
#16809 closed enhancement (fixed)
[PATCH] SlippyMapBBoxChooser: include tile sources from current layers
| Reported by: | ris | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | 18.10 |
| Component: | Core imagery | Version: | |
| Keywords: | slippymap minimap imagery tilesource layer | Cc: |
Description
The intent of this patch series is to allow tile sources to be selected in the SlippyMapBBoxChooser which are present in the layer manager but aren't in ImageryLayerInfo. How can this happen? Most often it's imagery that's been added through a remotecontrol command.
This required a small amount of refactoring to bring this about. getAllTileSources() now deduplicates the TileSources it finds ("duplicates" are considered to share a .getId() result). And because we're now making the sources list depend on something more volatile than before I thought it was necessary to handle the case where the currently-in-use TileSource is removed from the available sources. Previously it would mysteriously disappear from the menu leaving the user unable to see what the currently visible tileset is. Now it remains present until the selection changes again.
Extends tests to cover this.
See github PR https://github.com/openstreetmap/josm/pull/36
Attachments (4)
Change History (7)
by , 7 years ago
| Attachment: | v1-0001-SlippyMapBBoxChooser-correct-check-attempting-to-.patch added |
|---|
by , 7 years ago
| Attachment: | v1-0002-SlippyMapBBoxChooser-redesign-getAllTileSources-t.patch added |
|---|
by , 7 years ago
| Attachment: | v1-0003-SlippyMapBBoxChooser-also-gather-TileSources-from.patch added |
|---|
by , 7 years ago
| Attachment: | v1-0004-SlippyMapBBoxChooser-add-ability-to-listen-for-la.patch added |
|---|
comment:1 by , 7 years ago
comment:2 by , 7 years ago
| Milestone: | → 18.10 |
|---|
Patches are against r14299