Modify

Opened 6 weeks ago

Closed 6 weeks ago

#16809 closed enhancement (fixed)

[PATCH] SlippyMapBBoxChooser: include tile sources from current layers

Reported by: ris Owned by: team
Priority: minor Milestone: 18.10
Component: Core imagery Version:
Keywords: slippymap minimap imagery tilesource layer Cc:

Description

The intent of this patch series is to allow tile sources to be selected in the SlippyMapBBoxChooser which are present in the layer manager but aren't in ImageryLayerInfo. How can this happen? Most often it's imagery that's been added through a remotecontrol command.

This required a small amount of refactoring to bring this about. getAllTileSources() now deduplicates the TileSources it finds ("duplicates" are considered to share a .getId() result). And because we're now making the sources list depend on something more volatile than before I thought it was necessary to handle the case where the currently-in-use TileSource is removed from the available sources. Previously it would mysteriously disappear from the menu leaving the user unable to see what the currently visible tileset is. Now it remains present until the selection changes again.

Extends tests to cover this.

See github PR https://github.com/openstreetmap/josm/pull/36

Change History (7)

comment:1 Changed 6 weeks ago by ris

Patches are against r14299

comment:2 Changed 6 weeks ago by Don-vip

Milestone: 18.10

comment:3 Changed 6 weeks ago by Don-vip

Resolution: fixed
Status: newclosed

In 14300/josm:

fix #16809 - SlippyMapBBoxChooser: include tile sources from current layers (patch by ris, modified)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.