Opened 7 years ago

Last modified 3 years ago

#16803 reopened defect

Validator: Wrong warning Highway link is not linked to adequate highway/link — at Version 2

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc:

Description (last modified by Klumbumbus)

What steps will reproduce the problem?

  1. Open attached sample OSM file
  2. Run validator

What is the expected result?

No warning

What happens instead?

Highway link is not linked to adequate highway/link

Please provide any additional information below. Attach a screenshot if possible.

It is a common mapping method to draw one way which describes two separate link roads and I think it is correct. When I split the way at the node on the primary road the warning disappears. Maybe the validator code could "simulate" that split?


URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-10-01 23:59:36 +0200 (Mon, 01 Oct 2018)
Build-Date:2018-10-01 22:08:47
Revision:14289
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14289 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 2665 MB / 5376 MB (1522 MB allocated, but free)
Java version: 1.8.0_162-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34535)
+ apache-commons (34506)
+ buildings_tools (34572)
+ download_along (34503)
+ ejml (34389)
+ geotools (34513)
+ jts (34524)
+ measurement (34529)
+ merge-overlap (34664)
+ o5m (34405)
+ opendata (34675)
+ pbf (34576)
+ poly (34546)
+ reverter (34552)
+ utilsplugin2 (34506)

Last errors/warnings:
- W: Conflicts detected - <html>There were 8 conflicts detected.</html>
- W: Conflicts detected - <html>There was 1 conflict detected.</html>
- W: Conflicts detected - <html>There was 1 conflict detected.</html>
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- E: Handled by bug report queue: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=504, Error Header=<timeout. The server is probably too busy to handle your request.>, Error Body=<<?xml version="1.0" encoding="UTF-8"?>
- E: Communication with OSM server failed - ResponseCode=504, Error Header=&lt;timeout. The server is probably too busy to handle your request.&gt;, Error Body=&lt;&lt;?xml version="1.0" encoding="UTF-8"?&gt;
- W: java.net.SocketException: Unexpected end of file from server
- E: org.openstreetmap.josm.io.OsmTransferException: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server
- E: Network exception - <html>Failed to open a connection to the remote server<br>'https://api.openstreetmap.org/api/0.6/'.<br>Please check your internet connection.</html>

Change History (5)

by GerdP, 7 years ago

Attachment: sample.osm added

comment:1 by GerdP, 7 years ago

Thought again about this. Although it is a common way to map these roads with a single way the way needs to be split when a destination is added. Therefore JOSM should recognize this special case and propose a split instead of claiming that the wrong link type is used.
Esp. in this sample case JOSM doesn't complain when the way is tagged highway=unclassified_link, which is for sure a change to the worse (it was tagged like this in the past)

by Klumbumbus, 7 years ago

Attachment: 16803.png added

comment:2 by Klumbumbus, 7 years ago

Description: modified (diff)

by GerdP, 7 years ago

Attachment: sample2.osm added
Note: See TracTickets for help on using tickets.