non-reproducible crash when clicking a button in the settings menu

[Hupf]

What steps will reproduce the problem?

1. JOSM installed using josm-setup.exe running on Oracle Java 1.8 x64 with german UI, overwriting some (quite old) previous JOSM installation where the Kendzi3D plugin was loaded. In the current installation the plugin is not active.
2. On JOSM startup, observe a network error when fetching (kendzi-related) resources from non-resolvable hostname openstreetmap.org.pl
3. Do not load any data / open any files
4. Go to Advanced Settings, search for "kendzi" and multi-select the entries with key "mirror.*". Press the "Reset" button
5. Directly afterwards, press the "More..." button and observe the crash handler to appear (at the second attempt, this did no longer happen, neither after restarting JOSM)

What is the expected result?

When clicking "More...", a pop-up menu should appear (save/load/reset various profiles)
Navigating through the settings menu should not produce a crash handler.

What happens instead?

The pop-up menu did not appear, the crash happened immediately after clicking "More...".

Please provide any additional information below. Attach a screenshot if possible.

Since the error is not reproducible and only happened once, setting the priority to minor so it may be closed if the stacktrace is inconclusive.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-08-22 19:44:25 +0200 (Wed, 22 Aug 2018)
Build-Date:2018-08-22 17:46:33
Revision:14178
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14178 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1803 (17134)
Memory Usage: 951 MB / 2731 MB (321 MB allocated, but free)
Java version: 1.8.0_181-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 3840x2160
Maximum Screen Size: 3840x2160
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-69a2ca58, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=61977, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]

Plugins:
+ AddrInterpolation (34506)
+ ColorPlugin (1511895663)
+ DirectDownload (34593)
+ DirectUpload (34502)
+ ElevationProfile (34576)
+ FastDraw (34510)
+ FixAddresses (34511)
+ HouseNumberTaggingTool (34517)
+ ImageWayPoint (34206)
+ ImportImagePlugin (34576)
+ ImproveOsm (140)
+ ImproveWay (24)
+ Mapillary (v1.5.15)
+ MicrosoftStreetside (34577)
+ OpenStreetCam (162)
+ OpeningHoursEditor (34535)
+ RoadSigns (34553)
+ SeaChart (34237)
+ SeaMapEditor (34589)
+ ShapeTools (1230)
+ SimplifyArea (34586)
+ alignways (34489)
+ apache-commons (34506)
+ apache-http (34506)
+ areaselector (349)
+ austriaaddresshelper (1525848529)
+ buildings_tools (34572)
+ continuosDownload (1530471163)
+ contourmerge (v0.1.1)
+ download_along (34503)
+ editgpx (34506)
+ ejml (34389)
+ fieldpapers (v0.4.3)
+ geotools (34513)
+ gpsblam (34515)
+ gson (34389)
+ imagery_offset_db (34596)
+ jogl (1.2.1)
+ jts (34524)
+ junctionchecking (34525)
+ lakewalker (34468)
+ log4j (34527)
+ mapdust (34528)
+ markseen (7)
+ measurement (34529)
+ merge-overlap (34530)
+ openvisible (34536)
+ photoadjust (34543)
+ plastic_laf (34206)
+ splinex (34557)
+ turnlanes (34566)
+ turnrestrictions (34576)
+ utilsplugin2 (34506)
+ waydownloader (34569)
+ wikipedia (v1.1.0)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&preset
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/current/roofspresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Communication_Towers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColourTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Ph_Typhoon&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss

Validator rules:
+ resource://data/validator/power.mapcss

Last errors/warnings:
- W: [RELATION, CLOSEDWAY] Simple 3D buildings parts: Could not get presets icon http://openstreetmap.pl/kendzi/preset/3d_simple_icon_blue_32.png
- W: [RELATION, CLOSEDWAY] Simple 3D buildings outline: Could not get presets icon http://openstreetmap.pl/kendzi/preset/3d_simple_icon_green_32.png
- W: [RELATION, CLOSEDWAY] Colors and materials: Could not get presets icon http://openstreetmap.pl/kendzi/preset/building_colors_32.png
- W: [RELATION, CLOSEDWAY] Roof 3dr: Could not get presets icon http://openstreetmap.pl/kendzi/preset/roof_icon_red_32.png
- W: [RELATION, CLOSEDWAY] Roof shape: Could not get presets icon http://openstreetmap.pl/kendzi/preset/roof_icon_blue_32.png
- W: [RELATION, CLOSEDWAY] Roof lines: Could not get presets icon http://openstreetmap.pl/kendzi/preset/roof_icon_yellow_32.png
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Hinzufügen von resource://data/validator/power.mapcss zu Eigenschaftsprüfer fehlgeschlagen
- W: java.io.IOException: Das Öffnen eines Eingabestroms für die Resource 'resource://data/validator/power.mapcss' ist fehlgeschlagen.
- E: Handled by bug report queue: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (61) of javawsApplicationThreadGroup
java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location
	at java.awt.Component.getLocationOnScreen_NoTreeLock(Unknown Source)
	at java.awt.Component.getLocationOnScreen(Unknown Source)
	at javax.swing.JPopupMenu.show(Unknown Source)
	at org.openstreetmap.josm.gui.preferences.advanced.AdvancedPreference$2.actionPerformed(AdvancedPreference.java:176)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[Don-vip]

In 14248/josm:

fix #16730 - make sure we try to display popup menus only if their parent is visible on screen

[Don-vip]

In 14250/josm:

see #16730 - one file missed