Modify

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#16721 closed enhancement (fixed)

Presets for shop=shoes should include an element for "shoes:repair=yes|no"

Reported by: heilbron Owned by: team
Priority: minor Milestone: 18.09
Component: Internal preset Version:
Keywords: template_report shop shoes repair Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Select any POI with shop=shoes.
  2. The presets for shop=shoes are offered and can be chosen
  3. ... but they dont include a checkbox for the shoes:repair tag

What is the expected result?

A checkbox for shoes:repair (=yes|no) should be included in the presets, too.

What happens instead?

No preset für "shoes:repair=yes|no. Actually, it is missing in defaultpresets.xml.

Please provide any additional information below. Attach a screenshot if possible.

See wiki: https://wiki.openstreetmap.org/wiki/Tag:shop=shoes

Preset UI element should be called "Offers repairs" in English, and "Schuhreparaturen" in German.

Code for defaultpresets.xml could be:

<check key="shoes:repair" text="Offers repairs" />
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-08-22 19:44:25 +0200 (Wed, 22 Aug 2018)
Build-Date:2018-08-22 17:46:33
Revision:14178
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14178 en) Windows 10 64-Bit
OS Build number: Windows 8 Pro 1803 (17134)
Memory Usage: 291 MB / 989 MB (47 MB allocated, but free)
Java version: 1.8.0_181-b13, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1920x1200
Maximum Screen Size: 1920x1200
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (34517)
+ ImproveOsm (139)
+ Mapillary (v1.5.15)
+ QuickLabel (18)
+ RoadSigns (34553)
+ apache-commons (34506)
+ apache-http (34506)
+ buildings_tools (34572)
+ log4j (34527)
+ pt_assistant (v2.1.3)
+ public_transport (34548)
+ reverter (34552)
+ tag2link (34559)
+ turnlanes (34566)
+ turnrestrictions (34576)
+ utilsplugin2 (34506)
+ wikipedia (v1.1.0)

Tagging presets:
+ http://www.country-linedance.de/daten/Verkehrszeichen-vorlage.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&preset&zip=1
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/current/roofspresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&preset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ http://www.country-linedance.de/daten/Verkehrszeichen-vorlage.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TMC&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&style&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&style&zip=1
- C:\Dokumente und Einstellungen\SHALH\Eigene Dateien\OSM_GPX\SimpleRoofTags.mapcss
- C:\Dokumente und Einstellungen\SHALH\Eigene Dateien\OSM_GPX\SimpleBuildingTags.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Postcode&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&style&zip=1
- C:\Programme\JOSM\Styles_LessObtrusiveNodes-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&style&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Postcode&zip=1
- https://github.com/simon04/coloured-addresses.mapcss/raw/master/dist/coloured-addresses.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet

Attachments (0)

Change History (6)

comment:1 Changed 14 months ago by Don-vip

Keywords: shop shoes repair added
Milestone: 18.09

comment:2 Changed 14 months ago by Don-vip

Description: modified (diff)

comment:3 Changed 14 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14228/josm:

fix #16721 - add shoes:repair=yes|no to shop=shoe preset
fix #16722 - add self_service=yes|no and laundry_service=yes|no to shop=laundry preset

comment:4 Changed 14 months ago by heilbron

Hi @Don-vip,
could I have fixed that myself? Is there a web interface to defaultpresets.xml somewhere?
Thanke, Stephen

comment:5 Changed 14 months ago by Don-vip

Hi heilbron,
Thanks for asking this question :)
You can see the sources online:

You cannot modify sources directly here, but for simple issues we allow GitHub pull requests, just remember to always create a ticket here to notify us (otherwise the pull request is simply not seen).

For more advanced patches, you need to setup a development environment (see DevelopersGuide) and attach SVN patches to a new ticket. You need an SVN client to produce these patches (for example, Eclipse IDE or TortoiseSVN tool).

comment:6 in reply to:  5 Changed 14 months ago by heilbron

Replying to Don-vip:

Thank you very much - guess I should reduce mapping and learn github ;)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.