[PATCH] RemoteControlHttpsServer: end mainloop if server.isClosed()

[ris]

​https://github.com/openstreetmap/josm/pull/35

This importantly adds a line

                if (!server.isClosed()) {
                    Logging.error(e);
+               } else {
+                   // stop the thread automatically if server is stopped
+                   return;
                }

corresponding to a similar line in RemoteControlHttpServer which appears to be missing in RemoteControlHttpsServer, meaning that a RemoteControlHttpsServer thread that's been "stopped" would actually just spin forever, erroring on the closed ServerSocket.

Also in these patches I've ported the RemoteControlTest from JOSMFixture to JOSMTestRules and improved AddNodeHandlerTest's robustness by giving it the options it needs to be able to properly create a data layer.

And I really do think this has made appveyor's builds properly reliable now.

[ris]

(hold on, I've forgotten to remove the now-redundant JOSMFixture import...)

[Don-vip]

In 14217/josm:

fix #16705 - RemoteControlHttpsServer: end mainloop if server.isClosed() (patch by ris)

[Don-vip]

Thanks! :)

[Don-vip]

I removed the import, it's ok :)

[ris]

Ah well, also I somehow managed to remove the milestone flag from this ticket *shrug*

[ris]

Well done.

[Don-vip]

classic (and stupid) bug of Trac when conflicts arise. It's smart enough to detect conflicts but not to fix them!