Opened 7 years ago
Closed 2 years ago
#16696 closed enhancement (fixed)
Slows down JOSM when working with a lot of data
| Reported by: | naoliv | Owned by: | floscher |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin wikipedia | Version: | |
| Keywords: | performance | Cc: | simon04 |
Description
While working with a lot of data it's possible to see that JOSM gets really slow to basically do anything (even adding a simple node and some tags to it).
While profiling with visualvm I can see that the wikipedia plugins is using some considerable amount of CPU time:
From my ignorance, it seems that it's recalculating/updating something for every map change (which contributes for the general slowness), although I have not modified anything with a wikipedia/wikidata tag:
@Override public void processDatasetEvent(AbstractDatasetChangedEvent event) { updateWikipediaArticles(); list.repaint(); }
Can this be improved somehow, please?
JOSM:
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2018-08-29 23:16:52 +0200 (Wed, 29 Aug 2018) Revision:14204 Build-Date:2018-08-30 01:32:31 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (14204 en) Linux Debian GNU/Linux testing (buster) Memory Usage: 7168 MB / 7168 MB (5227 MB allocated, but free) Java version: 10.0.2+13-Debian-1, Oracle Corporation, OpenJDK 64-Bit Server VM Screen: :0.0 1600x900, :0.1 1280x1024 Maximum Screen Size: 1600x1024 Java package: openjdk-10-jre:amd64-10.0.2+13-1 Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21 VM arguments: [--add-modules=java.activation,java.se.ee, -Dawt.useSystemAAFontSettings=gasp] Program arguments: [--language=en] Dataset consistency test: No problems found Plugins: + ImportImagePlugin (34576) + OpeningHoursEditor (34535) + PicLayer (34544) + SimplifyArea (34586) + apache-commons (34506) + buildings_tools (34572) + download_along (34503) + editgpx (34506) + ejml (34389) + geojson (87) + geotools (34513) + jts (34524) + log4j (34527) + measurement (34529) + opendata (34576) + pbf (34576) + poly (34546) + reverter (34552) + scripting (30787) + tageditor (34560) + todo (30305) + turnlanes-tagging (272) + turnrestrictions (34576) + undelete (34568) + utilsplugin2 (34506) + wikipedia (v1.1.0)
Attachments (0)
Change History (3)
comment:1 by , 7 years ago
| Cc: | added |
|---|
comment:2 by , 7 years ago
comment:3 by , 2 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I think this is fixed as of v1.1.1 (see https://github.com/JOSM/wikipedia/commit/92c2aa65dccf2ca156ff422b84655319bdf632df ).




https://github.com/JOSM/wikipedia/commit/687142d4154d2307bb13ced19f727efba55b8e86 – Filter relevant DatasetChangedEvents