#16680 closed enhancement (fixed)
[PATCH] tests: PluginServer: fix for windows
| Reported by: | ris | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | 18.09 |
| Component: | Unit tests | Version: | |
| Keywords: | appveyor pluginserver ci | Cc: |
Description
https://github.com/openstreetmap/josm/pull/33
Turns out that some arcane systems by Microsoft still use backslashes as path separators.
This should fix PluginHandlerJOSMTooOldTest and PluginPreferenceHighLevelTest on windows. Additionally there is a patch which tweaks appveyor.yml to upload the full detailed test results as an artefact on_finish whether tests were successful or not. Very useful.
And with this, appveyor is our first reliably-passing pre-merge CI.
(travis is also reliably-passing to some extent, but I've gone and additionally enabled non-headless mode in its build matrix, which doesn't pass fully, making a first glance at any travis build look like a complete failure...)
Attaching patches...
Attachments (2)
Change History (6)
by , 7 years ago
| Attachment: | v1-0001-appveyor-attempt-to-push-test-results-on_finish-r.patch added |
|---|
by , 7 years ago
| Attachment: | v1-0002-PluginServer-ensure-jar-relative-path-is-stringif.patch added |
|---|
comment:1 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 7 years ago
| Milestone: | 18.09 |
|---|
I say reliably, but, still, DrawActionTest, it would seem...
(and actually, sometimes there's a hang after RemoteControlTest has been torn down, which is super weird)
comment:4 by , 7 years ago
| Milestone: | → 18.09 |
|---|
In 14179/josm: