Modify

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#16680 closed enhancement (fixed)

[PATCH] tests: PluginServer: fix for windows

Reported by: ris Owned by: team
Priority: minor Milestone: 18.09
Component: Unit tests Version:
Keywords: appveyor pluginserver ci Cc:

Description

https://github.com/openstreetmap/josm/pull/33

Turns out that some arcane systems by Microsoft still use backslashes as path separators.

This should fix PluginHandlerJOSMTooOldTest and PluginPreferenceHighLevelTest on windows. Additionally there is a patch which tweaks appveyor.yml to upload the full detailed test results as an artefact on_finish whether tests were successful or not. Very useful.

And with this, appveyor is our first reliably-passing pre-merge CI.

(travis is also reliably-passing to some extent, but I've gone and additionally enabled non-headless mode in its build matrix, which doesn't pass fully, making a first glance at any travis build look like a complete failure...)

Attaching patches...

Change History (6)

comment:1 Changed 6 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14179/josm:

fix #16680 - Unit tests: fix for windows (patch by ris)

comment:2 Changed 6 months ago by Don-vip

Milestone: 18.09

Thanks!

comment:3 Changed 6 months ago by ris

Milestone: 18.09

I say reliably, but, still, DrawActionTest, it would seem...

(and actually, sometimes there's a hang after RemoteControlTest has been torn down, which is super weird)

Last edited 6 months ago by ris (previous) (diff)

comment:4 Changed 6 months ago by Don-vip

Milestone: 18.09

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.