#16656 closed enhancement (fixed)
[PATCH] appveyor: tweak configuration and skip troublesome tests to get suite completing
Reported by: | ris | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 18.09 |
Component: | Unit tests | Version: | |
Keywords: | appveyor | Cc: |
Description
See https://github.com/openstreetmap/josm/pull/32
With these changes, the appveyor tests at least complete their test run and expose their results via the appveyor "test results" features whether all tests pass or not. The appveyor "success" of the test run also reflects whether any tests failed.
This does not make all the tests pass on appveyor yet, though I note that all of the failing tests (PluginHandlerJOSMTooOldTest
, PluginPreferenceHighLevelTest
) are mine, so that's my problem to sort out.
Out of interest, do people find PluginHandlerJOSMTooOldTest
and PluginPreferenceHighLevelTest
to be passing or failing on normal windows testruns?
Attaching patches...
Attachments (5)
Change History (14)
by , 7 years ago
Attachment: | v1-0001-appveyor-MainApplicationTest-skip-testSetupUIMana.patch added |
---|
by , 7 years ago
Attachment: | v1-0002-appveyor-don-t-run-javadoc-but-do-run-tests-in-ha.patch added |
---|
by , 7 years ago
Attachment: | v1-0003-appveyor-RemoteControlTest-mock-out-PlatformHookW.patch added |
---|
by , 7 years ago
Attachment: | v1-0004-appveyor-PlatformHookWindowsTest-skip-testSetupHt.patch added |
---|
by , 7 years ago
Attachment: | v1-0005-appveyor-attempt-to-push-test-results-on_finish-r.patch added |
---|
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Keywords: | appveyor added |
---|---|
Milestone: | → 18.09 |
comment:3 by , 7 years ago
Keywords: | appveyor removed |
---|---|
Milestone: | 18.09 |
Hmm. I don't think that was intentional - this patch has been kicking around for a while and it probably got mistakenly included in a rebase. Do remove it.
comment:4 by , 7 years ago
Keywords: | appveyor added |
---|---|
Milestone: | → 18.09 |
comment:6 by , 7 years ago
Tests on my Windows:
PluginPreferenceHighLevelTest
- testDisablePluginWithUpdatesAvailable OK
- testUpdateWithNoAvailableUpdates OK
- testInstallWithoutRestartRequired KO
java.lang.ClassCastException: java.lang.AssertionError cannot be cast to java.lang.Integer at org.openstreetmap.josm.gui.preferences.plugin.PluginPreferenceHighLevelTest.testInstallWithoutRestartRequired(PluginPreferenceHighLevelTest.java:808) at com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:73) at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:684)
- testInstallWithoutUpdate KO
java.lang.ClassCastException: java.lang.AssertionError cannot be cast to java.lang.Integer at org.openstreetmap.josm.gui.preferences.plugin.PluginPreferenceHighLevelTest.testInstallWithoutUpdate(PluginPreferenceHighLevelTest.java:224) at com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:73) at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:684)
- testUpdateOnlySelectedPlugin KO
java.lang.ClassCastException: java.lang.AssertionError cannot be cast to java.lang.Integer at org.openstreetmap.josm.gui.preferences.plugin.PluginPreferenceHighLevelTest.testUpdateOnlySelectedPlugin(PluginPreferenceHighLevelTest.java:474) at com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:73) at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:684)
PluginHandlerJOSMTooOldTest
- testUpdatePluginsSkipOne KO
java.lang.AssertionError: Unexpected ExtendedDialog content: JOSM version 7 001 required for plugin dummy_plugin. at org.openstreetmap.josm.testutils.mockers.ExtendedDialogMocker.getMockResult(ExtendedDialogMocker.java:95) at org.openstreetmap.josm.testutils.mockers.ExtendedDialogMocker.setVisible(ExtendedDialogMocker.java:132) at org.openstreetmap.josm.plugins.PluginDownloadTask.download(PluginDownloadTask.java:114) at org.openstreetmap.josm.plugins.PluginDownloadTask.realRun(PluginDownloadTask.java:175) at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:95) at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:143) at org.openstreetmap.josm.plugins.PluginHandler.updatePlugins(PluginHandler.java:1134) at org.openstreetmap.josm.plugins.PluginHandlerJOSMTooOldTest.testUpdatePluginsSkipOne(PluginHandlerJOSMTooOldTest.java:184) at com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:73) at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:684)
- testUpdatePluginsDownloadBoth KO
java.lang.AssertionError: Unexpected ExtendedDialog content: JOSM version 8 001 required for plugin baz_plugin. at org.openstreetmap.josm.testutils.mockers.ExtendedDialogMocker.getMockResult(ExtendedDialogMocker.java:95) at org.openstreetmap.josm.testutils.mockers.ExtendedDialogMocker.setVisible(ExtendedDialogMocker.java:132) at org.openstreetmap.josm.plugins.PluginDownloadTask.download(PluginDownloadTask.java:114) at org.openstreetmap.josm.plugins.PluginDownloadTask.realRun(PluginDownloadTask.java:175) at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:95) at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:143) at org.openstreetmap.josm.plugins.PluginHandler.updatePlugins(PluginHandler.java:1134) at org.openstreetmap.josm.plugins.PluginHandlerJOSMTooOldTest.testUpdatePluginsDownloadBoth(PluginHandlerJOSMTooOldTest.java:116) at com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:73) at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:684)
- testUpdatePluginsUnexpectedlyJOSMTooOld KO
org.junit.ComparisonFailure: expected:<[7]> but was:<[6]> at org.openstreetmap.josm.plugins.PluginHandlerJOSMTooOldTest.testUpdatePluginsUnexpectedlyJOSMTooOld(PluginHandlerJOSMTooOldTest.java:270) at com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:73) at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:684)
comment:7 by , 7 years ago
By the way do you think you could add a non-regression test for #16622? This one was really bad (my fault)
comment:8 by , 7 years ago
I'll put it on my list.
Surprised this is failing on windows - I've managed to get detailed test results exporting from appveyor now (that's one nice thing about appveyor over travis - built-in artifact & result storage) and from a quick glance it appears there's some sort of io error happening while downloading the plugin. Weird.
Why do you readd
.platform()
? I have deprecated it as it is no longer needed.