Modify

Opened 10 months ago

Last modified 10 months ago

#16637 new defect

Rework unit tests to not depend on external website

Reported by: Don-vip Owned by: team
Priority: normal Milestone:
Component: Unit tests Version:
Keywords: Cc: ris

Description

We still have some unit tests making real network connections, failing when the website is slow or unreachable:

  1. org.openstreetmap.josm.gui.oauth.OsmOAuthAuthorizationClientTest.testCookieHandling
  2. org.openstreetmap.josm.gui.preferences.server.ApiUrlTestTaskTest.testNominalUrl
  3. org.openstreetmap.josm.gui.preferences.server.ApiUrlTestTaskTest.testAlertInvalidServerResult
  4. org.openstreetmap.josm.io.OsmServerHistoryReaderTest.testWay
  5. org.openstreetmap.josm.io.OsmServerHistoryReaderTest.testNode
  6. org.openstreetmap.josm.tools.HttpClientTest.testOpenUrlBzip
  7. org.openstreetmap.josm.tools.HttpClientTest.testOpenUrlGzip
  8. org.openstreetmap.josm.tools.HttpClientTest.testTicket9660

Attachments (0)

Change History (2)

comment:1 Changed 10 months ago by ris

There also those that unintentionally make network requests, e.g. fetching the "start page" from the wiki.

comment:2 Changed 10 months ago by Don-vip

In 14191/josm:

see #16637 - javadoc

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Don-vip
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.