Troubleshoot DownloadWmsAlongTrackActionTest.testTMSLayer failure

[Don-vip]

Follow-up of #16010.

Test DownloadWmsAlongTrackActionTest.testTMSLayer fails on Jenkins since r14052:

org.awaitility.core.ConditionTimeoutException: Condition with org.openstreetmap.josm.gui.layer.gpx.DownloadWmsAlongTrackActionTest was not fulfilled within 10000 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:79)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:27)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860)
	at org.openstreetmap.josm.gui.layer.gpx.DownloadWmsAlongTrackActionTest.testTMSLayer(DownloadWmsAlongTrackActionTest.java:62)
	at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:689)

Until this is fixed, the test needs to be disabled to silence Jenkins notifications.

[Don-vip]

In 14116/josm:

see #16590 - ignore failing unit test

[ris]

I've narrowed this down - this fails when the test is run preceded by both org.openstreetmap.josm.actions.AddImageryLayerActionTest and org.openstreetmap.josm.actions.ExitActionTest.

[Don-vip]

Oh, great! :)

[ris]

Ah, duh, MainApplication.shutdown() also shuts down JCSCacheManager. Will mock that out.

[ris]

Tadaa ​https://github.com/openstreetmap/josm/pull/30

[Don-vip]

In 14126/josm:

fix #16590 - fix unit tests (patch by ris)

[Don-vip]

Thanks! :)

[ris]

Oh that's interesting - ExitActionTest itself failed now.

[ris]

It would help if I'd included Main.java in the patch...

[Don-vip]

In 14131/josm:

see #16590 - more fixes (patch by ris)
see #15229 - javadoc fixes

[Don-vip]

In 14132/josm:

see #16590 - remove unused import

[Don-vip]

In 14133/josm:

see #16590 - remove unused import