Modify

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#16590 closed defect (fixed)

Troubleshoot DownloadWmsAlongTrackActionTest.testTMSLayer failure

Reported by: Don-vip Owned by: ris
Priority: normal Milestone: 18.08
Component: Unit tests Version:
Keywords: Cc: wiktorn

Description

Follow-up of #16010.

Test DownloadWmsAlongTrackActionTest.testTMSLayer fails on Jenkins since r14052:

org.awaitility.core.ConditionTimeoutException: Condition with org.openstreetmap.josm.gui.layer.gpx.DownloadWmsAlongTrackActionTest was not fulfilled within 10000 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:79)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:27)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860)
	at org.openstreetmap.josm.gui.layer.gpx.DownloadWmsAlongTrackActionTest.testTMSLayer(DownloadWmsAlongTrackActionTest.java:62)
	at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:689)

Until this is fixed, the test needs to be disabled to silence Jenkins notifications.

Change History (15)

comment:1 Changed 9 months ago by Don-vip

In 14116/josm:

see #16590 - ignore failing unit test

comment:2 Changed 9 months ago by ris

I've narrowed this down - this fails when the test is run preceded by both org.openstreetmap.josm.actions.AddImageryLayerActionTest and org.openstreetmap.josm.actions.ExitActionTest.

Last edited 9 months ago by ris (previous) (diff)

comment:3 Changed 9 months ago by Don-vip

Oh, great! :)

comment:4 Changed 9 months ago by ris

Ah, duh, MainApplication.shutdown() also shuts down JCSCacheManager. Will mock that out.

comment:6 Changed 9 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 14126/josm:

fix #16590 - fix unit tests (patch by ris)

comment:7 Changed 9 months ago by Don-vip

Thanks! :)

comment:8 Changed 9 months ago by ris

Oh that's interesting - ExitActionTest itself failed now.

comment:9 Changed 9 months ago by ris

It would help if I'd included Main.java in the patch...

comment:10 Changed 9 months ago by Don-vip

In 14131/josm:

see #16590 - more fixes (patch by ris)
see #15229 - javadoc fixes

comment:11 Changed 9 months ago by Don-vip

In 14132/josm:

see #16590 - remove unused import

comment:12 Changed 9 months ago by Don-vip

In 14133/josm:

see #16590 - remove unused import

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ris.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.