Modify

Opened 22 months ago

Closed 22 months ago

Last modified 11 days ago

#16573 closed enhancement (wontfix)

Allow XN as Imagery country code

Reported by: Klumbumbus Owned by: stoecker
Priority: normal Milestone:
Component: Trac Version:
Keywords: Cc:

Description

In ELI the contry code of wiki:/Maps/Finland#Nordicsnowmobileoverlay was changed to XN. After checking https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2 and https://en.wikipedia.org/wiki/Nordic_Patent_Institute I think XN makes indeed more sense than FI, so I tried to change it but the wiki page didn't allow it.

Warnung: Ungültige Wiki-Seite: XML validation for map failed: Element '{http://josm.openstreetmap.de/maps-1.0}country-code': [facet 'enumeration'] The value 'XN' is not an element of the set {'EU', 'AF', 'AX', 'AL', 'DZ', 'AS', 'AD', 'AO', 'AI', 'AQ', 'AG', 'AR', 'AM', 'AW', 'AU', 'AT', 'AZ', 'BS', 'BH', 'BD', 'BB', 'BY', 'BE', 'BZ', 'BJ', 'BM', 'BT', 'BO', 'BQ', 'BA', 'BW', 'BV', 'BR', 'IO', 'BN', 'BG', 'BF', 'BI', 'KH', 'CM', 'CA', 'CV', 'KY', 'CF', 'TD', 'CL', 'CN', 'CX', 'CC', 'CO', 'KM', 'CG', 'CD', 'CK', 'CR', 'CI', 'HR', 'CU', 'CW', 'CY', 'CZ', 'DK', 'DJ', 'DM', 'DO', 'EC', 'EG', 'SV', 'GQ', 'ER', 'EE', 'ET', 'FK', 'FO', 'FJ', 'FI', 'FR', 'GF', 'PF', 'TF', 'GA', 'GM', 'GE', 'DE', 'GH', 'GI', 'GR', 'GL', 'GD', 'GP', 'GU', 'GT', 'GG', 'GN', 'GW', 'GY', 'HT', 'HM', 'VA', 'HN', 'HK', 'HU', 'IS', 'IN', 'ID', 'IR', 'IQ', 'IE', 'IM', 'IL', 'IT', 'JM', 'JP', 'JE', 'JO', 'KZ', 'KE', 'KI', 'KP', 'KR', 'KW', 'KG', 'LA', 'LV', 'LB', 'LS', 'LR', 'LY', 'LI', 'LT', 'LU', 'MO', 'MK', 'MG', 'MW', 'MY', 'MV', 'ML', 'MT', 'MH', 'MQ', 'MR', 'MU', 'YT', 'MX', 'FM', 'MD', 'MC', 'MN', 'ME', 'MS', 'MA', 'MZ', 'MM', 'NA', 'NR', 'NP', 'NL', 'NC', 'NZ', 'NI', 'NE', 'NG', 'NU', 'NF', 'MP', 'NO', 'OM', 'PK', 'PW', 'PS', 'PA', 'PG', 'PY', 'PE', 'PH', 'PN', 'PL', 'PT', 'PR', 'QA', 'RE', 'RO', 'RU', 'RW', 'BL', 'SH', 'KN', 'LC', 'MF', 'PM', 'VC', 'WS', 'SM', 'ST', 'SA', 'SN', 'RS', 'SC', 'SL', 'SG', 'SX', 'SK', 'SI', 'SB', 'SO', 'ZA', 'GS', 'SS', 'ES', 'LK', 'SD', 'SR', 'SJ', 'SZ', 'SE', 'CH', 'SY', 'TW', 'TJ', 'TZ', 'TH', 'TL', 'TG', 'TK', 'TO', 'TT', 'TN', 'TR', 'TM', 'TC', 'TV', 'UG', 'UA', 'AE', 'GB', 'US', 'UM', 'UY', 'UZ', 'VU', 'VE', 'VN', 'VG', 'VI', 'WF', 'EH', 'YE', 'ZM', 'ZW'}. 

Attachments (0)

Change History (13)

comment:1 Changed 22 months ago by Don-vip

It's being used by a patent organization? I don't know anyone knows what XN means without reading Wikipedia, it makes me think more about Xinjiang rather than "Nordic countries".

Instead of adding this unusual country code, I would prefer support a list of valid codes.

comment:2 Changed 22 months ago by stoecker

Resolution: wontfix
Status: newclosed

Another strange code. I see not reason to support these codes. They make no sense for imagery entries. And supporting them will break all older JOSM versions.

comment:3 in reply to:  1 Changed 22 months ago by Klumbumbus

Replying to Don-vip:

I don't know anyone knows what XN means without reading Wikipedia

Yeah, thats true. OK, so let's keep it as is or has anyone a better idea?

I would prefer support a list of valid codes.

Thats already implemented in trac.

comment:4 Changed 22 months ago by Don-vip

We already support layers defined for several countries? I don't remember about such feature, do we have an example?

comment:5 Changed 22 months ago by Klumbumbus

No, I meant that trac checks that the code is in its list of supported codes when editing a page. See error message below. (I misunderstood your comment.)

Warnung: Ungültige Wiki-Seite: XML validation for map failed: Element '{http://josm.openstreetmap.de/maps-1.0}country-code': [facet 'enumeration'] The value 'XN' is not an element of the set {'EU', 'AF', 'AX', 'AL', 'DZ', 'AS', 'AD', 'AO', 'AI', 'AQ', 'AG', 'AR', 'AM', 'AW', 'AU', 'AT', 'AZ', 'BS', 'BH', 'BD', 'BB', 'BY', 'BE', 'BZ', 'BJ', 'BM', 'BT', 'BO', 'BQ', 'BA', 'BW', 'BV', 'BR', 'IO', 'BN', 'BG', 'BF', 'BI', 'KH', 'CM', 'CA', 'CV', 'KY', 'CF', 'TD', 'CL', 'CN', 'CX', 'CC', 'CO', 'KM', 'CG', 'CD', 'CK', 'CR', 'CI', 'HR', 'CU', 'CW', 'CY', 'CZ', 'DK', 'DJ', 'DM', 'DO', 'EC', 'EG', 'SV', 'GQ', 'ER', 'EE', 'ET', 'FK', 'FO', 'FJ', 'FI', 'FR', 'GF', 'PF', 'TF', 'GA', 'GM', 'GE', 'DE', 'GH', 'GI', 'GR', 'GL', 'GD', 'GP', 'GU', 'GT', 'GG', 'GN', 'GW', 'GY', 'HT', 'HM', 'VA', 'HN', 'HK', 'HU', 'IS', 'IN', 'ID', 'IR', 'IQ', 'IE', 'IM', 'IL', 'IT', 'JM', 'JP', 'JE', 'JO', 'KZ', 'KE', 'KI', 'KP', 'KR', 'KW', 'KG', 'LA', 'LV', 'LB', 'LS', 'LR', 'LY', 'LI', 'LT', 'LU', 'MO', 'MK', 'MG', 'MW', 'MY', 'MV', 'ML', 'MT', 'MH', 'MQ', 'MR', 'MU', 'YT', 'MX', 'FM', 'MD', 'MC', 'MN', 'ME', 'MS', 'MA', 'MZ', 'MM', 'NA', 'NR', 'NP', 'NL', 'NC', 'NZ', 'NI', 'NE', 'NG', 'NU', 'NF', 'MP', 'NO', 'OM', 'PK', 'PW', 'PS', 'PA', 'PG', 'PY', 'PE', 'PH', 'PN', 'PL', 'PT', 'PR', 'QA', 'RE', 'RO', 'RU', 'RW', 'BL', 'SH', 'KN', 'LC', 'MF', 'PM', 'VC', 'WS', 'SM', 'ST', 'SA', 'SN', 'RS', 'SC', 'SL', 'SG', 'SX', 'SK', 'SI', 'SB', 'SO', 'ZA', 'GS', 'SS', 'ES', 'LK', 'SD', 'SR', 'SJ', 'SZ', 'SE', 'CH', 'SY', 'TW', 'TJ', 'TZ', 'TH', 'TL', 'TG', 'TK', 'TO', 'TT', 'TN', 'TR', 'TM', 'TC', 'TV', 'UG', 'UA', 'AE', 'GB', 'US', 'UM', 'UY', 'UZ', 'VU', 'VE', 'VN', 'VG', 'VI', 'WF', 'EH', 'YE', 'ZM', 'ZW'}.

comment:6 Changed 22 months ago by Don-vip

OK. Dirk would you be ok to support several country codes for a single imagery entry?:

- <xs:element name="country-code" minOccurs="0" maxOccurs="1" type="tns:iso3166" />
+ <xs:element name="country-code" minOccurs="0" maxOccurs="unbounded" type="tns:iso3166" />

comment:7 Changed 22 months ago by Klumbumbus

That would distort the layout of the table in the josm preferences!?

comment:8 Changed 22 months ago by Don-vip

We should adopt a special rendering, maybe "*" with a tooltip.

comment:9 in reply to:  6 ; Changed 22 months ago by anonymous

Replying to Don-vip:

OK. Dirk would you be ok to support several country codes for a single imagery entry?:

Simply don't use the entry in this case.

No entry does not mean "Worldwide", but means "not in a single country".

comment:10 Changed 22 months ago by stoecker

Ooops, Forgot to login.

comment:11 in reply to:  9 ; Changed 5 weeks ago by skyper

Replying to stoecker:

Replying to Don-vip:

OK. Dirk would you be ok to support several country codes for a single imagery entry?:

Simply don't use the entry in this case.

It is still set to FI but covers Finland, Norway, Sweden and at least parts of Denmark.
Does it make sense to add subpages for continents in order to collect imagery entries for only the continent or even parts of it like Scandinavia in this case?

comment:12 in reply to:  11 ; Changed 5 weeks ago by stoecker

Replying to skyper:

Replying to stoecker:

Replying to Don-vip:

OK. Dirk would you be ok to support several country codes for a single imagery entry?:

Simply don't use the entry in this case.

It is still set to FI but covers Finland, Norway, Sweden and at least parts of Denmark.
Does it make sense to add subpages for continents in order to collect imagery entries for only the continent or even parts of it like Scandinavia in this case?

The pages are only convention. We can add whatever is necessary. Vincent already complained, that some country based pages are growing too much. The country code is another matter. If FI is wrong, remove it and add a note why not to set FI (or someone will add it later again).

comment:13 in reply to:  12 Changed 11 days ago by Klumbumbus

Replying to stoecker:

The pages are only convention. We can add whatever is necessary. Vincent already complained, that some country based pages are growing too much.

I renamed the page Maps/USA now to Maps/USA States and split up Maps/USA Country. Lets see if this helps a bit for the USA case.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain stoecker.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.