Modify ↓

Opened 8 months ago

Closed 8 months ago

#16557 closed defect (fixed)

Cardinal direction roles likely should not be reversed or even suggested for reversing when the member (way) is reversed

Reported by: Simon Poole Owned by: team
Priority: normal Milestone: 18.08
Component: Core Version:
Keywords: relation role cardinal direction Cc: stoecker

Description

See ​https://github.com/openstreetmap/iD/pull/2004#issuecomment-408071091

As the cardinal direction role of a way in a route relation does not depend on the drawing direction of the OSM element, it is difficult to see how this could ever be correct.

Attachments (0)

Change History (6)

comment:1 Changed 8 months ago by Don-vip

Keywords: relation role cardinal direction added

comment:2 Changed 8 months ago by Don-vip

Cc: stoecker added

Dirk: Why did you add it?

comment:3 Changed 8 months ago by stoecker

You really ask me why I did something 8 years ago? :-)

Very likely there was a reason. I can only speculate: As these are relevant for reversed ways they should be in the dialog even if they stay unchanged....

comment:4 in reply to:  3 Changed 8 months ago by Don-vip

Replying to stoecker:

You really ask me why I did something 8 years ago? :-)

I was feeling lucky today :) Also I read what happened 8 years ago on Trac (tickets modified etc.) and I failed to understand why you did this particular change.

comment:5 Changed 8 months ago by Don-vip

Milestone: → 18.08

comment:6 Changed 8 months ago by Don-vip

Resolution: → fixed
Status: new → closed

In 14085/josm:

fix #16557 - drop east/west/north/south roles reversion. No one knows why we added it in the first place

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.