Modify

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#16543 closed enhancement (fixed)

[Patch] Enable downloading of Multiple Tracks and use names, add track info to tracks and use tags

Reported by: reubot Owned by: reubot
Priority: normal Milestone:
Component: Plugin DirectDownload Version:
Keywords: Cc:

Description


Attachments (3)

directdownload.patch (8.1 KB) - added by reubot 10 months ago.
directdownload.34484.patch (1.9 KB) - added by reubot 10 months ago.
Fix crash when gpx contains multiple segments
directdownload.34485.patch (694 bytes) - added by reubot 10 months ago.
Fix crash when gpx contains multiple segments

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 months ago by reubot

This patch enables downloading of multiple tracks, and sets the track name properly.

comment:2 Changed 11 months ago by Don-vip

Summary: Enable downloading of Multiple Tracks and use names[Patch] Enable downloading of Multiple Tracks and use names

comment:3 Changed 11 months ago by Don-vip

Owner: changed from team to reubot
Status: newneedinfo

Thanks for the patch!

Some remarks to take into account:

  • please run "ant checkstyle" and fix the reported errors
  • please don't comment existing code
  • what's about this TODO?

comment:4 Changed 10 months ago by reubot

Hi, I have updated the patch to conform to the code style and removed the TODO.

Changed 10 months ago by reubot

Attachment: directdownload.patch added

comment:5 Changed 10 months ago by Don-vip

Resolution: fixed
Status: needinfoclosed

Applied in [o34481:34482]. Thanks!

comment:6 Changed 10 months ago by reubot

Resolution: fixed
Status: closedreopened
Summary: [Patch] Enable downloading of Multiple Tracks and use names[Patch] Enable downloading of Multiple Tracks and use names, add track info to tracks and use tags

Hi, sorry to reopen, but I just realised I introduced a crash in the plugin when a gpx file contains more than one segment.

Changed 10 months ago by reubot

Attachment: directdownload.34484.patch added

Fix crash when gpx contains multiple segments

comment:7 Changed 10 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

Applied in [o34485:34486].

Changed 10 months ago by reubot

Attachment: directdownload.34485.patch added

Fix crash when gpx contains multiple segments

comment:8 Changed 10 months ago by reubot

Hi I added a minor update to the last patch (I made a mistake when making the previous diff to the updated JOSM core)

Sorry for all the bother.

Last edited 10 months ago by reubot (previous) (diff)

comment:9 Changed 10 months ago by reubot

Resolution: fixed
Status: closedreopened

comment:10 Changed 10 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

Applied in [o34593:34594].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain reubot.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.