Modify

Attachments (0)

Change History (14)

comment:1 Changed 13 months ago by naoliv

Probably the same fix (and same problem) from #11286

comment:2 in reply to:  1 Changed 13 months ago by anonymous

Replying to naoliv:

Probably the same fix (and same problem) from #11286

Yes, it's the same topic. In the meantime, is has already been implemented in cgimap, only the Rails port is still missing (but not used anyway for this call): https://github.com/openstreetmap/openstreetmap-website/pull/1189

comment:3 Changed 13 days ago by mmd

Priority: normalcritical

I'm increasing the priority of this issue to critical as a follow up for https://lists.openstreetmap.org/pipermail/talk-gb/2019-August/023327.html

This mapping accident which moved a large number of nodes (>100k) in London took several hours to revert, due to the slow download of object versions in JOSM reverter. Please consider switching to Multi Fetch (https://wiki.openstreetmap.org/wiki/API_v0.6#Multi_fetch:_GET_.2Fapi.2F0.6.2F.5Bnodes.7Cways.7Crelations.5D.3F.23parameters) instead of downloading each object version one by one. Refer to API documentation for some example calls.

comment:4 Changed 13 days ago by stoecker

Priority: criticalnormal

comment:5 Changed 13 days ago by mmd

@steocker: why did you reduce the priority to normal? Being able to quickly repair bad edits is essential, now that the changeset upload is no longer handled by the Rails port.

comment:6 Changed 13 days ago by stoecker

A bug which affects only few people and which is not causing a total failure is a normal priority.

comment:7 Changed 12 days ago by Upliner

Fixed in [o35078]
PS: sorry for garbled commit message, I wasn't here for long time and forgot how to use ant publish

comment:8 Changed 12 days ago by Upliner

Resolution: fixed
Status: newclosed

comment:9 Changed 12 days ago by GerdP

I did not yet try it but I think the new code is not properly handling the case when one or more of the requested elements don't exist? See #17291 for my work on this in core.

comment:10 Changed 12 days ago by Upliner

GerdP, see ChangesetReverter.java lines 247-259, I wrote them specifically for this issue. But I haven't tested this case either. If you have a changeset number where this issue happens, I will be able to test it.

comment:11 Changed 12 days ago by mmd

Maybe one of the changesets including redactions would be useful here, like https://www.openstreetmap.org/user/pnorman%20redaction%20revert

I know that reverter plugin blacklists two known revertion users. For testing purposes you could try and disable this check in ChangesetReverter.java

comment:12 in reply to:  10 Changed 12 days ago by GerdP

Replying to Upliner:

GerdP, see ChangesetReverter.java lines 247-259, I wrote them specifically for this issue. But I haven't tested this case either. If you have a changeset number where this issue happens, I will be able to test it.

Ah, okay, I didn't understand that this code handles the problem.
BTW: Great performance improvement! I tried to code that a few month ago for the core method and failed.

Last edited 12 days ago by GerdP (previous) (diff)

comment:13 in reply to:  7 Changed 12 days ago by Don-vip

Replying to Upliner:

Fixed in [o35078]
PS: sorry for garbled commit message, I wasn't here for long time and forgot how to use ant publish

Thanks a lot for resuming your work on this plugin :)

comment:14 Changed 12 days ago by mmd

Thanks a lot, performance improvement is truly impressive!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Upliner.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.