Opened 23 months ago

Closed 19 months ago

Last modified 19 months ago

#16494 closed enhancement (fixed)

Download dialogue: Download as new layer option could be a button instead

Reported by: wulfmorn Owned by: simon04
Priority: normal Milestone: 18.11
Component: Core Version:
Keywords: download Cc:

Description (last modified by Klumbumbus)

Its an easy mistake to forget to check or uncheck the download as new layer button. My suggestion is to remove the checkbox and have two download buttons:

Download into new layer | Download into current layer | Cancel | Help

Perhaps bind them as "Enter" and "Shift+Enter". Enter being the "OK" button means you'd only have to remember what Shift does (new or current layer) - this rather than two different buttons for each option.

Attachments (4)

dlnew_mergeinto.png (23.0 KB) - added by wulfmorn 23 months ago.
download-to-new.png (8.3 KB) - added by simon04 20 months ago.
download-to-existing.png (8.0 KB) - added by simon04 20 months ago.
2018-10-30-233146_998x577_scrot.png (67.3 KB) - added by simon04 19 months ago.

Download all attachments as: .zip

Change History (13)

Changed 23 months ago by wulfmorn

Attachment: dlnew_mergeinto.png added

comment:1 Changed 23 months ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 22 months ago by Don-vip

Agreed. Any idea about the icon?

comment:3 Changed 22 months ago by Klumbumbus

A combination of source:trunk/images/download.png and source:trunk/images/dialogs/layerlist.png and maybe also the star of source:trunk/images/new.svg?

comment:4 Changed 22 months ago by Wulfmorn

my thought would be:

download_icon + layer_icon -> download to new layer
download_icon + plus_icon -> download to same layer

Changed 20 months ago by simon04

Attachment: download-to-new.png added

Changed 20 months ago by simon04

Attachment: download-to-existing.png added

comment:5 Changed 20 months ago by simon04

Milestone: 18.11

Icon proposals: ,

comment:6 Changed 20 months ago by simon04

Owner: changed from team to simon04

comment:7 Changed 19 months ago by simon04

Resolution: fixed
Status: newclosed

In 14391/josm:

fix #16494 - Download dialog: Download as new layer as button

Changed 19 months ago by simon04

comment:8 Changed 19 months ago by simon04

Should we adapt the dialog "Download object" as well?

comment:9 Changed 19 months ago by aseerel4c26

This conflicted with my habits...

I just was about to post this to ticket #17024 : "With version 14447 I miss(!) the "download into new layer" checkbox in the download window. I have one (unsaved, unuploaded, modified) datalayer active." However, I just found the new button(!) - uff... that is hard for someone who is used to the checkbox since ages. In fact I was confused in the last days why the hell the download window opened at startup - apparently I have ticked the "open this dialogue at startup" accidentally, when wanting to download into a new layer, because the checkbox is at the position of the old "new layer" checkbox.

How to solve? Do not really know. Maybe one time after updating to a new version: highlight the new button in glowing red? Maybe someone else has a better idea. In fact it could be that we simply need to let the users run into this wall a bit. ;-) Anyway, thanks for the new button, which is really a good idea.

(Update:) For the "tested" JOSM users a startup page news mention of this change may be justified.

Last edited 19 months ago by aseerel4c26 (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.