Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#16454 closed defect (fixed)

JOSM plugins build broken by latest wikipedia change

Reported by: Don-vip Owned by: floscher
Priority: normal Milestone:
Component: Plugin wikipedia Version:
Keywords: Cc:

Description

See https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/jdk=JDK8/1286/console

I guess you switched to JUnit5? JOSM core and all plugins should probably switch simultaneously.

Attachments (0)

Change History (3)

comment:1 Changed 3 months ago by floscher

Oops, sorry, I didn't mean to. Seems I used the wrong import statement for some new unit test classes.

comment:2 Changed 3 months ago by floscher

Resolution: fixed
Status: newclosed

Fixed in https://github.com/JOSM/wikipedia/commit/af1f64c74c5c03a4b2042d4d7a0b8565b74d386e .

Sidenote regarding a switch to JUnit 5: With JUnit 5 you can still run unit tests written for JUnit 3 or 4. So the build tool can already switch to JUnit 5 before all tests are converted (if needed).
That's what I currently do in the Gradle build of the wikipedia plugin: JUnit 5 runs the unit tests using the so called Vintage engine, which can run unit tests written for JUnit 4.

comment:3 in reply to:  2 Changed 3 months ago by Don-vip

Replying to floscher:

Sidenote regarding a switch to JUnit 5: With JUnit 5 you can still run unit tests written for JUnit 3 or 4. So the build tool can already switch to JUnit 5 before all tests are converted (if needed).

Ah, good to know, I'll update then. I was afraid of needing to update all our tests (I already upgraded from JUnit 3 to 4 but we had considerably less tests then).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain floscher.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.