Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1642 closed enhancement (fixed)

[PATCH] Filter and color based on [P|H]DOP

Reported by: anonymous Owned by: framm
Priority: minor Milestone:
Component: Core Version:
Keywords: gpx trail; visualize data quality; dispersion to color Cc:

Description

sometimes we need precise measurements and there should be a way to tell the precision of gps points and maybe filter them.

Attachments (5)

dilution2.diff (7.9 KB) - added by anonymous 11 years ago.
diff patch color-encoded h-dilution
Color by Dilution.patch (21.5 KB) - added by xeen 11 years ago.
Based on h-a-l-9000's patch
Color by Dilution.2.patch (21.5 KB) - added by xeen 11 years ago.
Look like trac ate some chars. I believe I know what you meant, here's an updated patch
nmea_fix.diff (2.1 KB) - added by h-a-l-9000@… 11 years ago.
hdilution.png (7.9 KB) - added by h-a-l-9000@… 11 years ago.
Tracks drawn with new color scheme

Download all attachments as: .zip

Change History (17)

comment:1 Changed 11 years ago by h-a-l-9000@…

I have such a patch, maybe I'll post it some time.

http://home.arcor.de/h-a-l-9000/img2/dilution.png

comment:2 Changed 11 years ago by Hasienda

Keywords: gpx trail visualize data quality dispersion to color added
Summary: Filter and color based on HDOPFilter and color based on [P|H]DOP

Please add the patch here. I'd like to use it too, but I'm no Java code writer. With the patch this should be a cheap improvement and make it's way much sooner into JOSM trunk.

HDOP might be enough, but since PDOP is a professional standard, it would be better to have this in place, or even an option to choose a dispersion type, if dataset has multiple of them.

comment:3 Changed 11 years ago by h-a-l-9000@…

Isn't PDOP just a combination of HDOP and VDOP? In a 2D-Editor the elevation precision shouldn't be that important...

Adding the patch (diff). The JOSM devs are probably not too happy with it as it is a quick hack I made to be able to map my tracks properly. It only works with GPX files as for NMEA import I use my NMEA improvement patch (adding both patches won't work either as there is a small dependency between the two).

If this does have a future it would be neat if the OSM server provided dilution data for GPS points. Seems not too common in the data of other users though.

Changed 11 years ago by anonymous

Attachment: dilution2.diff added

diff patch color-encoded h-dilution

comment:4 Changed 11 years ago by anonymous

Summary: Filter and color based on [P|H]DOP[PATCH] Filter and color based on [P|H]DOP

comment:5 Changed 11 years ago by anonymous

Summary: [PATCH] Filter and color based on [P|H]DOPFilter and color based on [P|H]DOP

I don't like the patch as it is.

  • Too many changes which are unrelated
  • No switch to turn this on/off.

Changed 11 years ago by xeen

Attachment: Color by Dilution.patch added

Based on h-a-l-9000's patch

comment:6 Changed 11 years ago by xeen

Summary: Filter and color based on [P|H]DOP[Patch?] Filter and color based on [P|H]DOP

This implements dilution using the same color system that is used by velocity. It also makes coloring work with lines disabled (for all modes) and colors GPS points like it would color the lines (not sure it was intentional to style them differently).

Since I have no GPX file with HDOP information, I couldn't test it properly.

On a side: Is it normal that small GPS points don't render anymore? For some reason drawRect(x, y, 0, 0) seemed to work before but now doesn't. Suggestions welcome.

comment:7 Changed 11 years ago by stoecker

Summary: [Patch?] Filter and color based on [P|H]DOP[PATCH] Filter and color based on [P|H]DOP

A single note after reading patch:

I prefer

..................

.........

compared to

..............

.........

because this make breaking lines more obvious. A normal statement can't start with
or && or +.

Will test that patch later.

Changed 11 years ago by xeen

Attachment: Color by Dilution.2.patch added

Look like trac ate some chars. I believe I know what you meant, here's an updated patch

comment:8 Changed 11 years ago by h-a-l-9000@…

Two things:

  • The NMEA importer needs to be updated too, I attach the patch.
  • My good tracks are purple/blue, the bad ones have red and green in them - doesn't match the description green = good and red = bad.

Otherwise nice work. I'm missing the "legend" though, maybe I'll make that myself. Thinking about an icon in the upper toolbar.

Changed 11 years ago by h-a-l-9000@…

Attachment: nmea_fix.diff added

comment:9 in reply to:  8 Changed 11 years ago by anonymous

Replying to h-a-l-9000@arcor.de:

  • My good tracks are purple/blue, the bad ones have red and green in them - doesn't match the description green = good and red = bad.

Do you refer to your original patch or my updated patch? I changed the colors to use the red/green scheme in order to avoid having to draw a legend. It's easier to grasp a shade of colors compared to 10 random ones, too. If it draws this "weird" like you explained with my patch, could you please send the file to me so I can test locally? If you have privacy concerns, you can also send it to stefan@… .

comment:10 Changed 11 years ago by anonymous

I understand now what is happening - your coloring scheme resembles the Light spectrum with blue and ultraviolet (purple) as the "best" colors.
http://en.wikipedia.org/wiki/File:Electromagnetic-Spectrum.png

In the display preferences dialog it says red = high, green = low, thus the confusion. Should say blue/purple = low. And no, please don't dumb it down to red-green.

I'm attaching a screenshot with some tracks drawn with the new color scheme.

Changed 11 years ago by h-a-l-9000@…

Attachment: hdilution.png added

Tracks drawn with new color scheme

comment:11 Changed 11 years ago by anonymous

Resolution: fixed
Status: newclosed

In r1425.

comment:12 Changed 11 years ago by xeen

We should probably change the wording in the preferences then. Got any good suggestions that make it understandable without having to add a legend? I used red/green because these are pretty much the colors you see everyday when using color by velocity.

If dilution is always pretty low we might want to change it. Currently it is:

Dilution of Position (red = high, green = low, if available)

hmm maybe:

Dilution of Position (red = high, blue = low, if available)

Not sure people understand the light spectrum (red yellow green is pretty obvious, e.g. traffic lights) but blue?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.