Modify

#16361 closed task (fixed)

Shortcut warnings

Reported by: Don-vip Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc: stoecker

Description

I don't understand the warnings:

ERROR   src/org/openstreetmap/josm/actions/ReorderImageryLayersAction.java#33   Shortcut.registerShortcut("imagery:reorderbis", "Reorder imagery layers", VK_SQUARE, Shortcut.DIRECT));}
ERROR   src_plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/PTAssistantPlugin.java#79      addMenu("File", /* I18N: mnemonic: F */ trc("menu", "Public Transport"),

What's wrong?

Attachments (0)

Change History (7)

comment:1 Changed 18 months ago by stoecker

The parser is very simple.

For the second line the comment inside may be the issue. Moving the comment outside (in front of addMenu) will help. For the first I don't see the reason ATM. I'll have a look.

comment:2 Changed 18 months ago by Don-vip

VK_SQUARE is a custom constant because there is no Java constant for this key.

comment:3 Changed 18 months ago by stoecker

How does VK_SQUARE work then? For me it is ALTGR+2.

Last edited 18 months ago by stoecker (previous) (diff)

comment:4 Changed 18 months ago by Don-vip

I should have called it VK_TILDE. It's the key on the left of '1' key, it's being used by ² on French AZERTY but ~ on QWERTY.

comment:5 Changed 18 months ago by stoecker

Can you fix the PT assistant, I'll fix the josmcron for the other case?

comment:6 Changed 18 months ago by Don-vip

Done in [o34258].

comment:7 Changed 17 months ago by stoecker

Resolution: fixed
Status: newclosed

Ooops. Nearly forgot it.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.