Modify ↓

Opened 17 years ago

Closed 16 years ago

#1635 closed defect (fixed)

[PATCH] NullPointer in DirectUpload Plugin

Reported by: nagi@… Owned by: xeen
Priority: trivial Milestone:
Component: Plugin Version: latest
Keywords: NullPointer; DirectUpload Cc: xeen

Description

Hi
-using Tolls/Upload Traces with a GPX file.

  • Let tags empty (as this could be in the web frontend)

-> NPE

Regards

Attachments (2)

NPE_DirectUpload.txt​ (2.0 KB ) - added by nagi@… 17 years ago.
NPE Stack Trace
ImproveDirectUploadPlugin.patch​ (21.6 KB ) - added by xeen 16 years ago.
Improve Direct Upload Plugin

Download all attachments as: .zip

Change History (8)

by nagi@…, 17 years ago

Attachment: NPE_DirectUpload.txt​ added

NPE Stack Trace

comment:1 by Subhodip Biswas <subhodipbiswas@…>, 17 years ago

Owner: changed from framm to anonymous
Status: new → assigned

comment:2 by Hasienda, 16 years ago

Keywords: NullPointer DirectUpload added

#1637 is a duplicate ticket but still has a clearer error message, where it reads here "Unknown Source"

comment:3 by stoecker, 16 years ago

Owner: changed from anonymous to Subhodip Biswas <subhodipbiswas@…>
Status: assigned → new

comment:4 by anonymous, 16 years ago

Duplicate: #1884

comment:6 by xeen, 16 years ago

Cc: xeen added
Owner: changed from Subhodip Biswas <subhodipbiswas@…> to xeen
Summary: NullPointer in DirectUpload Plugin → [PATCH] NullPointer in DirectUpload Plugin

I thought this was nice and easy…

The patch does the following:

  • use JOSM provided base64 converting
  • Dialog Facelift (center screen, borders, translatable, dialog title, etc.)
  • Fix indentation (and remove those "auto generate" comments)
  • Auto select GPX layer if only one is available (and copies filename to description)
  • Fix the NullPointer issue (hopefully I didn't introduce new ones)
  • Fix special character handling so that the upload doesn't fail

It's still far from perfect, most obviously it should use the main worker to upload instead of hanging when clicking "upload". Will probably add this in a later patch, it's not my top priority.



by xeen, 16 years ago

Attachment: ImproveDirectUploadPlugin.patch​ added

Improve Direct Upload Plugin

comment:7 by anonymous, 16 years ago

Resolution: → fixed
Status: new → closed

Fixed in 13373.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain xeen.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.