Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1627 closed defect (fixed)

[PATCH] Bugfix for plugin activation

Reported by: egore911@… Owned by: framm
Priority: trivial Milestone:
Component: unspecified Version: latest
Keywords: Cc:

Description

I updated a plugin recently and I had issues when it was activated. I'm not sure if this is because of java 1.6 but File.delete() returns false if the file does not exist. But this is the case if the plugin is installed at a different place before the update. I.e. Gentoo installs all plugins to /usr/lib/josm/plugins/ and loads them from there. But updating the plugins will put them to %HOME%/.josm/plugins. And calling delete on the %HOME%/.josm/plugins file will not work. The attached patch works around that. It also verifies that the user is allowed to activate the plugins (has write-capability).

Attachments (1)

josm-plugin-activation.java (1.1 KB) - added by egore911@… 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by egore911@…

Attachment: josm-plugin-activation.java added

comment:1 Changed 11 years ago by anonymous

Component: Coreunspecified
Priority: majortrivial
Summary: Bugfix for plugin activation[PATCH] Bugfix for plugin activation

actually this seems to be a workaround for broken installations

comment:2 Changed 11 years ago by anonymous

Resolution: fixed
Status: newclosed

Fixed in #1017.

comment:3 Changed 11 years ago by anonymous

Aehm r1017 :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.