validator about landuse and building on the same object

[dieterdreist]

What steps will reproduce the problem?

1. add landuse and building tags on the same object

What is the expected result?

nothing

What happens instead?

"suspicious tagging combination" is raised

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-04-02 23:20:00 +0200 (Mon, 02 Apr 2018)
Build-Date:2018-04-03 01:33:52
Revision:13595
Redirecting:to URL 'https://josm.openstreetmap.de/svn/trunk':
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13595 en) Mac OS X 10.13.3
OS Build number: Mac OS X 10.13.3 (17D102)
Memory Usage: 878 MB / 1820 MB (182 MB allocated, but free)
Java version: 1.8.0_144-b01, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 188875522 1920x1080, Display 458628992 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
+ ColorPlugin (1511895663)
+ Create_grid_of_ways (34109)
+ ImportImagePlugin (34109)
+ PicLayer (34109)
+ ShapeTools (1230)
+ apache-commons (34109)
+ buildings_tools (34109)
+ editgpx (34109)
+ ejml (34126)
+ fieldpapers (v0.4.3)
+ geochat (34109)
+ geojson (80)
+ geotools (34125)
+ imagery_offset_db (34109)
+ jts (34038)
+ log4j (34038)
+ mbtiles (a3e491d)
+ measurement (34109)
+ o5m (34109)
+ osmarender (34096)
+ pbf (34109)
+ photo_geotagging (34109)
+ reltoolbox (34130)
+ reverter (34109)
+ undelete (34109)
+ utilsplugin2 (34109)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Cannot start IPv4 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- W: Cannot start IPv6 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect

[Klumbumbus]

Which specific tags? I can't think of a useful usecase atm. Landuse is usually put on larger areas.

[dieterdreist]

for example landuse=retail in a block (i.e. no outdoor area associated). Generally I don’t think it is a problem to have smaller landuse units, mapping style is not something josm should care for.

[stoecker]

Please give an example (i.e. an osm file). Sure does josm validate mapping style. That's the whole idea of the validator.

[dieterdreist]

example suspicious tag combination building landuse

[Klumbumbus]

In 13645/josm:

fix #16157 - don't warn about landuse=retail + building combination

[Klumbumbus]

I checked ​osmwiki:Key:landuse and retail seems to be really the only value which can be limited to a building. All other landuse tags have related sourrounding infrastructure.

[maraf]

building together with landuse=retail is indeed strange combination. I always remove landuse from such objects, building=retail is just enough.

[anonymous]

you should not do it, building is about a building type and landuse about current landuse. Also people might only look ar landuse and drop the buildings.

[anonymous]

In that case I would create another area object and tag it as landuse=retail. One for building and one for landuse is good method, as there is no confusing about which object some tags refer to, e.g. name.
Besides, I don't really understand why this change has to be limited only to landuse=retail? The next good condidate is landuse=commercial.

[Klumbumbus]

In 14275/josm:

fix #16783, see #16157 - fix validator warning message (modified patch by naoliv)