Add compatibility with Java 11

[Don-vip]

Follow-up of #15560

First ​EA builds of Java 11 are available.

Issues:

1. ​WebStart will be removed in Java 11!
2. Wiremock 2.13.0 ​uses javax.xml.bind.DatatypeConverter class which has been ​removed in JEP 320 => Solved by updating to 2.15
3. Jacoco does not ​support Java 11 yet Jacoco 0.8.2 released with java 11/12 support
4. ​JDK-8198899: Signature of WindowsPreferences methods changes (hkey changed from int to long)
5. ​Nashorn JavaScript Engine is deprecated!
6. JMockit ​is not compatible with Java 11 yet

See #16498 for Java 12 compatibility.

[Don-vip]

Right now the build fails with:

compile-jmapviewer:
    [javac] Compiling 50 source files to /var/lib/jenkins/jobs/Java-EarlyAccess-JOSM/workspace/jdk/JDK11/build
    [javac] /var/lib/jenkins/jobs/Java-EarlyAccess-JOSM/workspace/jdk/JDK11/src/org/jdesktop/swinghelper/debug/CheckThreadViolationRepaintManager.java:19: error: cannot access WeakReference
    [javac] import java.lang.ref.WeakReference;
    [javac]                     ^
    [javac]   bad class file: /modules/java.base/java/lang/ref/WeakReference.class
    [javac]     class file has wrong version 55.0, should be 53.0
    [javac]     Please remove or make sure it appears in the correct subdirectory of the classpath.
    [javac] 1 error

[Don-vip]

In 13492/josm:

see #15560, see #16047 - disable error_prone on Java 10+, see ​https://github.com/google/error-prone/issues/860

[Don-vip]

Now the tests fail due to removal of EE APIs: [junit] java.lang.module.FindException: Module java.se.ee not found

[Don-vip]

In 13505/josm:

see #16047 - do not add EE modules with Java 11+

[Don-vip]

Now jacoco crashes:

[jacoco:coverage] Enhancing junit with coverage
    [junit] FATAL ERROR in native method: processing of -javaagent failed
    [junit] java.lang.reflect.InvocationTargetException
    [junit]     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [junit]     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    [junit]     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    [junit]     at java.base/java.lang.reflect.Method.invoke(Method.java:564)
    [junit]     at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:510)
    [junit]     at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:522)
    [junit] Caused by: java.lang.RuntimeException: Class java/lang/UnknownError could not be instrumented.
    [junit]     at org.jacoco.agent.rt.internal_36ebf62.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:139)
    [junit]     at org.jacoco.agent.rt.internal_36ebf62.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:100)
    [junit]     at org.jacoco.agent.rt.internal_36ebf62.PreMain.createRuntime(PreMain.java:55)
    [junit]     at org.jacoco.agent.rt.internal_36ebf62.PreMain.premain(PreMain.java:47)
    [junit]     ... 6 more
    [junit] Caused by: java.lang.NoSuchFieldException: $jacocoAccess
    [junit]     at java.base/java.lang.Class.getField(Class.java:1958)
    [junit]     at org.jacoco.agent.rt.internal_36ebf62.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:137)
    [junit]     ... 9 more

[Don-vip]

(this was expected as ​Jacoco does not yet support Java 10, because of slow ASM releases...)

[Don-vip]

In 13523/josm:

see #16047 - disable jacoco on Java 11+, see ​https://github.com/jacoco/jacoco/issues/629

[Don-vip]

In 13524/josm:

see #16047 - update to awaitility-3.1.0

[Don-vip]

In 13525/josm:

see #16047 - update to wiremock-2.15.0

[Don-vip]

Java 11 build is stable! :)

[Don-vip]

Jacoco issue for Java 11: ​https://github.com/jacoco/jacoco/issues/663

[Don-vip]

Finally some possible good news for WebStart: ​https://lists.openstreetmap.org/pipermail/josm-dev/2018-April/008023.html

[Don-vip]

In 13651/josm:

see #16047 - make WinRegistry class work both with Java 8 and 11

[Don-vip]

In 13695/josm:

see #15560, see #16047 - detect java 10/11 packages

[Don-vip]

In 13700/josm:

see #15560, see #16047 - detect java 10/11 packages

[Don-vip]

In 13715/josm:

see #16047 - implement workaround against problem seen with IcedTeaWeb 1.7.1 / Java 9 on Debian

[Don-vip]

In 13716/josm:

see #16047 - catch correct exception

[Don-vip]

In 13819/josm:

see #2089, see #16047 - move JavaFX classes to their own package in order to exclude them automatically when JavaFX is not on the classpath (needed for Java 11+ now that FX is gone)

[Don-vip]

In 13820/josm:

see #16047 - tune add-exports options for Java 11

[Don-vip]

In 13821/josm:

fix #16308, see #16047 - remove blank png icon. With jdk-11-ea+14 JOSM fails to load it (ImageProvider returns null). JDK bugs:

• ​https://bugs.openjdk.java.net/browse/JDK-6574555
• ​https://bugs.openjdk.java.net/browse/JDK-6788458

[stoecker]

Hmm, the function should be in ImageProvider.

[Don-vip]

In 13823/josm:

see #9984, see #16047 - Java 11 handles transparent PNG out of the box, disable JOSM mechanisms to force transparency on this version

[Don-vip]

In 13944/josm:

see #16047 - Java 11 ea has trouble to access Google in https; don't care reporting issues now

[Don-vip]

In 13984/josm:

see #16047 - move method to ImageProvider

[Don-vip]

A Java WebStart alternative: ​https://github.com/threerings/getdown

[Don-vip]

In 13990/josm:

see #16047 - don't ask Java 8 users to upgrade to Java 10

[Don-vip]

In 14002/josm:

see #16047 - update to equalsverifier 2.4.8 for Java 11 compatibility, see ​https://github.com/jqno/equalsverifier/issues/197

[Don-vip]

Updates on plugin side:

[o34409] fix JAXB builds
[o34408] fix XJC scripts
[o34388] add JAF 1.2.0 from ​https://github.com/javaee/activation/releases/tag/JAF-1_2_0
[o34377] add svn:executable bit
[o34376] fix JAXB build
[o34375] include JAXB, removed in JDK11
[o34373] restore target=1.8, remove add-modules option for javac targets
[o34368] remove target=1.8, keep only source=1.8
[o34367] add java.activation,java.se.ee modules for Java 9/10
[o34366] add java.activation,java.se.ee modules for Java 9/10
[o34364] fix java version
[o34363] Add compatibility with Java 10/11

[Don-vip]

In 14033/josm:

see #16047 - update to Groovy 2.5.1 (includes update to ASM 6.2 for Java 11 compatibility)

[Don-vip]

In 14034/josm:

see #16047 - Patch Groovy 2.5.1 to add proper Java 11 compatibility:

• cherry-pick ​https://github.com/apache/groovy/pull/768/commits/a86e2527d5577c606a579c0fca12b0a344ddc770
• see ​https://issues.apache.org/jira/browse/GROOVY-8688
• see ​https://github.com/don-vip/groovy/tree/2_5_1_jdk11

[Don-vip]

News:

• Hendrik Ebbers started a project to offer a ​Java Web Start replacement
• He wrote a very interesting ​blog post
• Oracle ​didn't like it :D
• I managed to get from an (annoying) Oracle guy ​an important information: In October, Java 10 on Windows/mac will offer to downgrade to Java 8 so that WebStart and security updates are still provided!

[Don-vip]

In 14109/josm:

see #15560, see #16047 - make error_prone work on Java 10/11. For details refer to:

• ​https://github.com/google/error-prone/issues/860
• ​https://github.com/google/error-prone/issues/1086

[Don-vip]

In 14110/josm:

see #16047 - Oracle JDK? nope

[Don-vip]

We should keep an eye how Minecraft Java Edition and Minecraft Launcher evolve in the next months:

• ​https://minecraft.gamepedia.com/Java_Edition
• ​https://minecraft.gamepedia.com/Minecraft_launcher
• ​https://bugs.mojang.com/projects/MCL/issues/

I guess it will be as complex for them than us.

[Don-vip]

In 14171/josm:

see #16047, see #16498 - update to jacoco 0.8.2.20180819 for Java 11 compatibility. Keep it disabled for Java 12

See ​https://github.com/jacoco/jacoco/issues/663