Context Navigation

Modify ↓

#15560 closed enhancement (fixed)

Add compatibility with Java 10

Reported by:	Don-vip	Owned by:	team
Priority:	normal	Milestone:	18.03
Component:	Core	Version:
Keywords:	java10	Cc:

Description (last modified by Don-vip)

Follow-up of #11924.
Unlike Java 9, Java 10 will be far less disruptive.
The code freeze will start on 14th December, very soon with the new release cycle.

See #16047 for Java 11 compatibility.

Attachments (1)

hurray.PNG (2.9 KB ) - added by Don-vip 7 years ago.

Download all attachments as: .zip

Change History (36)

comment:1 by Don-vip, 7 years ago

In 13073/josm:

see #11924 - see #15560 - support jdk10+ in build.xml, update to proguard 6.0beta1 and error_prone 2.1.2

comment:2 by Don-vip, 7 years ago

In 13076/josm:

see #15560 - fix javadoc warnings with recent JDKs

comment:3 by Don-vip, 7 years ago

In 13077/josm:

see #15560 - fix javadoc warning with recent JDKs

comment:4 by Don-vip, 7 years ago

In 13079/josm:

see #15560 - EqualsVerifier does not work with newer Java versions -> disable tests automatically in this case
Workaround to https://github.com/jqno/equalsverifier/issues/177 / https://github.com/raphw/byte-buddy/issues/370
Inspired by https://issues.apache.org/jira/browse/SOLR-11606

comment:5 by Don-vip, 7 years ago

In 13096/josm:

see #15560 - add additionalCoverage optional build parameter to record coverage of classes outside of JOSM (to cover JDK EA classes)

comment:6 by Don-vip, 7 years ago

In 13097/josm:

see #15560 - add jacoco.inclbootstrapclasses and jacoco.inclnolocationclasses optional build parameters to record coverage of classes outside of JOSM (to cover JDK EA classes)

comment:7 by Don-vip, 7 years ago

In 13103/josm:

see #15560 - repair coverage, fix typo, increase integration test timeout

comment:8 by Don-vip, 7 years ago

In 13110/josm:

see #15560 - update to equalsverifier 2.4 (support of Java 10)

comment:9 by Don-vip, 7 years ago

Milestone:	17.12 → 18.01

Same problem than with Java 9, ASM has not yet released a compatible version, this causes jacoco to break.

Last edited 7 years ago by Don-vip (previous) (diff)

comment:10 by Don-vip, 7 years ago

In 13305/josm:

see #15560 - custom version of jacoco 0.8.1-SNAPSHOT (8685ca83dd562f3df9d2c8221ed5b928b36ebf62 + patch) + asm 6.1-beta (58b93c69)
see https://github.com/jacoco/jacoco/issues/629#issuecomment-356136388

comment:11 by Don-vip, 7 years ago

In 13306/josm:

see #15560 - Double.Double() is deprecated

comment:12 by Don-vip, 7 years ago

In 13342/josm:

see #15560 - Update to equalsverifier 2.4.2 (see https://github.com/jqno/equalsverifier/issues/183)

comment:13 by Don-vip, 7 years ago

Milestone:	18.01 → 18.02

Still waiting for ASM, as usual...

Last edited 7 years ago by Don-vip (previous) (diff)

comment:14 by Don-vip, 7 years ago

Milestone:	18.02 → 18.03

comment:15 by Don-vip, 7 years ago

javabug:8194955 => We have now a javadoc warning: You have not specified the version of HTML to use.

Last edited 7 years ago by Don-vip (previous) (diff)

comment:16 by Don-vip, 7 years ago

In 13491/josm:

see #11924, see #15560, see #16048 - explicitly generate HTML4 javadoc until all errors/warnings are fixed

comment:17 by Don-vip, 7 years ago

In 13492/josm:

see #15560, see #16047 - disable error_prone on Java 10+, see https://github.com/google/error-prone/issues/860

comment:18 by Don-vip, 7 years ago

In 13493/josm:

see #11924, see #15560, see #16048 - tt HTML tag is deprecated in HTML5: use code instead

comment:19 by Don-vip, 7 years ago

In 13494/josm:

see #11924, see #15560, fix #16048: Generate HTML5 javadoc with Java 9/10/11

name HTML attribute is deprecated in HTML5: use id instead

comment:20 by Don-vip, 7 years ago

javabug:8183518 => New deprecation warning: getMenuShortcutKeyMask() in Toolkit has been deprecated

comment:21 by Don-vip, 7 years ago

In 13504/josm:

see #11924, see #15560 - fix deprecation warning with Java 10

comment:22 by Don-vip, 7 years ago

In 13519/josm:

see #15560 - upgrade to equalsverifier-2.4.4 (contains ASM 6.1 for Java 10 compatibility)

comment:23 by Don-vip, 7 years ago

We now have a single test failing with Java 10: ProjectionRegressionTest.testNonRegression. Again tiny differences in numeric computations, like in #11889 / #13387 with Java 9.