Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#15883 closed enhancement (fixed)

[PATCH] Zoom on element when double-clicking on elements of upload window

Reported by: bagage Owned by: team
Priority: normal Milestone: 18.04
Component: Core Version: latest
Keywords: Cc:

Description

From the ulpoad window, when double-clicking items in added/updated/removed lists, this automatically centers the map on it. It's useful when you see something wrong on the list and you want to double-check before upload.

Attachments (1)

0001-Zoom-on-element-when-double-clicking-on-elements-of-.patch (3.4 KB) - added by bagage 2 years ago.
patch proposal

Download all attachments as: .zip

Change History (9)

Changed 2 years ago by bagage

patch proposal

comment:1 Changed 2 years ago by Don-vip

the listeners are never removed, did you check it does not cause a memory leak?

comment:2 Changed 2 years ago by Don-vip

Owner: changed from team to bagage
Status: newneedinfo

comment:3 Changed 2 years ago by bagage

I'll check that -- if you have any documentation about how to do that I'll take it, thanks!

comment:4 Changed 2 years ago by bagage

From what I'm looking I don't think there will be any memory leak -- once the UploadDialog is disposed, so be the uploaded lists.
UploadDialog also registers some listener on the lists:

        pnlUploadedObjects.addPropertyChangeListener(
                pnlBasicUploadSettings.getUploadParameterSummaryPanel()
        );

While never removing them; hence I believe the code expects the garbage collector to free memory once the dialog becomes useless?

Last edited 2 years ago by Don-vip (previous) (diff)

comment:5 Changed 2 years ago by Don-vip

Milestone: 18.04
Owner: changed from bagage to team
Status: needinfonew

comment:6 Changed 2 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 13660/josm:

fix #15883 - Zoom on element when double-clicking on elements of upload window (patch by bagage)

comment:7 Changed 2 years ago by Don-vip

Thanks for the patch! Sorry it took so long to merge.

comment:8 Changed 2 years ago by Klumbumbus

Nice feature!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.