#15883 closed enhancement (fixed)
[PATCH] Zoom on element when double-clicking on elements of upload window
Reported by: | bagage | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 18.04 |
Component: | Core | Version: | latest |
Keywords: | Cc: |
Description
From the ulpoad window, when double-clicking items in added/updated/removed lists, this automatically centers the map on it. It's useful when you see something wrong on the list and you want to double-check before upload.
Attachments (1)
Change History (9)
by , 7 years ago
Attachment: | 0001-Zoom-on-element-when-double-clicking-on-elements-of-.patch added |
---|
comment:1 by , 7 years ago
the listeners are never removed, did you check it does not cause a memory leak?
comment:2 by , 7 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
comment:3 by , 7 years ago
I'll check that -- if you have any documentation about how to do that I'll take it, thanks!
comment:4 by , 7 years ago
From what I'm looking I don't think there will be any memory leak -- once the UploadDialog is disposed, so be the uploaded lists.
UploadDialog also registers some listener on the lists:
pnlUploadedObjects.addPropertyChangeListener( pnlBasicUploadSettings.getUploadParameterSummaryPanel() );
While never removing them; hence I believe the code expects the garbage collector to free memory once the dialog becomes useless?
comment:5 by , 6 years ago
Milestone: | → 18.04 |
---|---|
Owner: | changed from | to
Status: | needinfo → new |
patch proposal