Modify

Opened 17 years ago

Closed 17 years ago

#1586 closed enhancement (fixed)

[PATCH] support for regional names

Reported by: stephankn Owned by: framm
Priority: major Milestone:
Component: unspecified Version: latest
Keywords: Cc:

Description

The order in which names are used can be configured using mappaint.nameOrder.
Default is to first try "name:en name:de int_name". The key "name" is always tried as a fallback.

Patch enclosed

Attachments (2)

regionalNames.patch (2.0 KB ) - added by stephankn 17 years ago.
patch that implements the functionality
MapPaintVisitor.java.patch (2.1 KB ) - added by stephankn 17 years ago.
corrected patch implementing functionality

Download all attachments as: .zip

Change History (6)

by stephankn, 17 years ago

Attachment: regionalNames.patch added

patch that implements the functionality

comment:1 by anonymous, 17 years ago

please re-submit this patch matching the style of the changed file (tabs/spaces).

Also, you might want to spend a couple of minutes to find out how the get the current locale instead of hardcoding "en, de" into the default. (PS: That would be "Locale.getDefault().getLanguage()" (yes, Language, not Country))

comment:2 by anonymous, 17 years ago

Summary: support for regional names[PATCH] support for regional names

comment:3 by stephankn, 17 years ago

re-supply patch. Changed indentation to use tabs. Determine current system locale to use as default for name. Two-level fallback: Try "int_name" as a default after current locale. Always look into "name", regardless of what is specified in properties.

by stephankn, 17 years ago

Attachment: MapPaintVisitor.java.patch added

corrected patch implementing functionality

comment:4 by anonymous, 17 years ago

Resolution: fixed
Status: newclosed

Separation character should be ";" and not " ", as this is used everywhere else.

Applied as r1019.

NOTE that the order is "locale;name;int_name" now.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.