Modify

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#15766 closed defect (fixed)

Lag when drawing ways with many nodes

Reported by: anonymous Owned by: team
Priority: normal Milestone: 18.01
Component: Core Version: tested
Keywords: template_report performance regression Cc:

Description

What steps will reproduce the problem?

  1. Download some data
  2. Draw way with draw tool (Shortcut A) with > 300 nodes

What is the expected result?

No lag. From my experience with the version before this one (13170) 600+ nodes are possible without noticeable lag.

What happens instead?

Drawing becomes near impossible with >400 nodes, new nodes are displayed at a rate of about 1 node/second even when clicking much faster.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-12-31 03:09:43 +0100 (Sun, 31 Dec 2017)
Build-Date:2017-12-31 02:33:46
Revision:13265
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13265 en) Mac OS X 10.7.5
OS Build number: Mac OS X 10.7.5 (11G63)
Memory Usage: 1566 MB / 3556 MB (869 MB allocated, but free)
Java version: 1.8.0_152-b16, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 458676592 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (33735)
+ utilsplugin2 (33991)
+ wikipedia (33993)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1

Last errors/warnings:
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.io.IOException: Attribution is not loaded yet
- W: java.net.SocketException: Connection reset
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out

Attachments (1)

15766.png (65.6 KB) - added by Don-vip 6 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 months ago by Don-vip

Keywords: performance added

comment:2 Changed 6 months ago by Don-vip

I can reproduce the performance penalty, but only with filter dialog open.

comment:3 Changed 6 months ago by Don-vip

Keywords: regression added
Milestone: 18.01

comment:4 Changed 6 months ago by Don-vip

performance regression of r13229.

DrawAction.getPreservedPrimitives() is now significantly slower but called a lot by filter execution on data changed event:


Changed 6 months ago by Don-vip

Attachment: 15766.png added

comment:5 Changed 6 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13309/josm:

fix #15766, see #15688 - fix performance regression introduced in r13229 when drawing a way of many nodes while the filter dialog is open

comment:6 Changed 6 months ago by Don-vip

In 13312/josm:

see #15766 - fix java warning

comment:7 Changed 6 months ago by Don-vip

In 13313/josm:

see #15766 - fix java warning

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.