Modify

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#15746 closed defect (fixed)

Validator wrong message, "area is unnecessary for leisure"

Reported by: dieterdreist Owned by: team
Priority: normal Milestone: 18.01
Component: Core validator Version:
Keywords: area leisure track Cc: Klumbumbus

Description

How would JOSM know about all leisure tags? Area=yes/no is unnecessary for leisure=pitch/swimming_pool/beach_resort and a lot of others, but it is necessary for leisure=<user defined> and leisure=track.

Attachments (0)

Change History (5)

comment:1 Changed 4 months ago by Don-vip

Checks is defined as follows:

area:closed[amenity ][area?][!highway],
area:closed[building][area?],
area:closed[landuse ][area?][!highway],
area:closed[leisure ][area?][!highway],
area:closed[natural ][area?],
area:closed[shop    ][area?] {
  throwWarning: tr("{0} is unnecessary for {1}", "{2.key}", "{1.key}");
  group: tr("unnecessary tag");
  fixRemove: "{2.key}";
}

comment:2 Changed 4 months ago by Don-vip

Keywords: area leisure added

comment:3 Changed 4 months ago by Don-vip

Cc: Klumbumbus added
Keywords: track added

We should probably disable the test for leisure=track

comment:4 Changed 4 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 13302/josm:

fix #15746 - don't warn about area=* on leisure=track and leisure=slipway

comment:5 Changed 4 months ago by Klumbumbus

Milestone: 18.01
Version: latest

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.