[PATCH] PluginHandler.installDownloadedPlugins: check downloaded plugin is valid *before* we delete any existing one
Creating this in parallel with https://github.com/openstreetmap/josm/pull/22 for the lovely pre-merge CI.
Small one here - noticed that the current behaviour of
PluginHandler.installDownloadedPlugins could prove to be more than a little annoying - only checking for corruption of the newly downloaded plugin after it's already deleted an existing one. Someone getting repeatedly corrupted downloads or having limited internet connectivity would lose their probably-previously-working plugin.
Also added a couple of tests covering this, requiring some additions to the underlying test infrastructure, including
JOSMTestRules which should come in handy when testing any functionality around version-checking.
Not sure if you actually want me to bother posting all the
.patch files here too seeing as it's just as easy to get them out of git...
new → closed