Opened 3 years ago

Closed 3 years ago

#15725 closed enhancement (fixed)

Remove location=kiosk from possible values for power substation's location=*

Reported by: francois.lacombe Owned by: francois.lacombe
Priority: normal Milestone: 18.01
Component: Internal preset Version:
Keywords: power, location, kiosk Cc:



Due to recent discussion about power substations hosted in cabinet, tagging has been updated to use man_made=street_cabinet + street_cabinet=power instead of location=kiosk.

Can you please remove this value 'kiosk' from the list for location=key used in power substation preset please?

Since a power street cabinet preset already exists, this is not necessary to add anything else.

Thanks in advance

Attachments (0)

Change History (11)

comment:1 Changed 3 years ago by Don-vip

Component: CoreInternal preset
Keywords: presets removed
Milestone: 18.01

comment:2 Changed 3 years ago by Don-vip

Owner: changed from team to francois.lacombe
Status: newneedinfo

There are more than 8000 occurences of location=kiosk, are you going to replace them all? Or is the key still used for other power features?

comment:3 Changed 3 years ago by francois.lacombe

They will be carefully replaced in next months.

location=kiosk isn't a recommended value anymore.
It was used only on transformers and substation before man_made=street_cabinet was introduced.

comment:4 Changed 3 years ago by mkoniecz

I think that in this case it is better to remove it from presets once usage is lower.

comment:5 Changed 3 years ago by francois.lacombe

How would it be lower if users still see it in presets ?

It would even need a validation rule encouraging users to move location=kiosk to man_made=street_cabinet.

comment:6 Changed 3 years ago by anonymous

How would it be lower if users still see it in presets ?

Retagging existing entries?

comment:7 in reply to:  6 Changed 3 years ago by francois.lacombe

Replying to anonyme:

Retagging existing entries?

Sure, but if it's still in presets, some other mappers will continue to add objects with location=kiosk
Then, if we retag existing ones, new ones won't stop to appear :(

comment:8 Changed 3 years ago by Klumbumbus

I think location=kiosk is used for transformers or substations like this or this. Those which you can enter like a "real" kiosk. This contradicts the definition of man_made=street_cabinet "A street cabinet [...] being of a size or contruction that workers cannot enter themselves. Thus it is an opposite of technical buildings where humans can walk inside."

comment:9 Changed 3 years ago by francois.lacombe

Hi Klumbumbus,

I got the idea, but your examples are mapped with building=yes
Location=kiosk was used to map such things : where no one can get in. It's exactly the same as street cabinets.
See the examples here :
If kiosk wasn't the right term for enclosures where no technician can enter, street_cabinet is surely better.

It's true that both location=kiosk and man_made=street_cabinet apply to substations and transformers. Difference between both is a substation got one or several transformers inside among other devices like switches.

comment:10 Changed 3 years ago by Don-vip

For reference, location=kiosk is used with:

  • 6970 power=substation
  • 1051 power=transformer

comment:11 Changed 3 years ago by Don-vip

Resolution: fixed
Status: needinfoclosed

In 13286/josm:

fix #15725 - remove location=kiosk from default power presets

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain francois.lacombe.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.