Modify

Opened 11 months ago

Closed 11 months ago

Last modified 9 months ago

#15716 closed defect (fixed)

ImageryOffsetDialog doesn't close pressing Esc

Reported by: skorbut Owned by: team
Priority: normal Milestone: 18.01
Component: Core imagery Version: latest
Keywords: Cc:

Description

  1. Download some OSM data
  2. Load aerial imagery, e.g. Bing
  3. In the layers menu right-click on Bing -> New offset. A window appears.
  4. Press Esc -> the window disappears.

I would now expect to be able to create new nodes, etc. However, it seems (based on the downloaded OSM data) that the user is now stuck in the offset-adjustment-mode, where one can adjust the imagery offset by click-and-holding the left mouse button.

The bug seems to reside somewhere at

  • src/org/openstreetmap/josm/actions/ImageryAdjustAction
  • src/org/openstreetmap/josm/gui/ExtendedDialog.setupEscListener()

but I was not able to find out more.

Attachments (0)

Change History (5)

comment:1 Changed 11 months ago by Don-vip

Milestone: 18.01

comment:2 Changed 11 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13269/josm:

fix #15716 - proper exit of imagery offset mapmode

comment:3 Changed 11 months ago by skorbut

Resolution: fixed
Status: closedreopened
Version: latest

@Don-vip:

Thanks for your quick reaction. I have two remarks regarding your fix:

  1. If I move the imagery layer using left-click and move, then decide to abort and therefore press Esc, the imagery layer will still have this unwanted offset applied. :-(
  2. Would it be possible to change the code so that pressing Esc closes the imagery offset dialog even when it isn't in focus?

Thank you for your efforts!

comment:4 Changed 11 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 13287/josm:

fix #15716 - listen to escape key outside of imagery adjust dialog, and restore correct offset when pressing it

comment:5 Changed 9 months ago by Don-vip

In 13433/josm:

fix #15849, see #15716 - IAE when changing active layer while setting offset

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.