AssertionError while replacing geometry (two closed ways)

[Don-vip]

What steps will reproduce the problem?

1. Select way 282225753 and new one overlapping with it
2. Replace geometry

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2017-12-29 16:43:19
Revision:13257
Is-Local-Build:true

Identification: JOSM/1.5 (13257 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1709 (16299)
Memory Usage: 1318 MB / 1797 MB (559 MB allocated, but free)
Java version: 1.8.0_152-b16, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-ea, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Plugins:
+ DxfImport (1012)
+ Mapillary (v1.5.9)
+ apache-commons (33668)
+ apache-http (32699)
+ cadastre-fr (33922)
+ ejml (32680)
+ geotools (33958)
+ imagery-xml-bounds (33830)
+ jts (32699)
+ pbf (33568)
+ public_transport (33817)
+ reverter (33865)
+ turnrestrictions (33780)
+ utilsplugin2 (33742)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/New%20basic%20style&zip=1

Last errors/warnings:
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2013. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2011. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2011. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2007. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2007. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2007. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2007. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2007. Using EPSG:3857.
- W: Unable to find supported projection for layer Toulouse - Orthophotoplan 2007. Using EPSG:3857.
- E: Handled by bug report queue: java.lang.AssertionError


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (19) of main
java.lang.AssertionError
	at edu.princeton.cs.algs4.AssignmentProblem.<init>(AssignmentProblem.java:52)
	at org.openstreetmap.josm.plugins.utilsplugin2.replacegeometry.ReplaceGeometryUtils.buildReplaceWayCommand(ReplaceGeometryUtils.java:306)
	at org.openstreetmap.josm.plugins.utilsplugin2.replacegeometry.ReplaceGeometryUtils.buildReplaceWayWithNewCommand(ReplaceGeometryUtils.java:236)
	at org.openstreetmap.josm.plugins.utilsplugin2.replacegeometry.ReplaceGeometryUtils.buildReplaceWithNewCommand(ReplaceGeometryUtils.java:60)
	at org.openstreetmap.josm.plugins.utilsplugin2.replacegeometry.ReplaceGeometryAction.actionPerformed(ReplaceGeometryAction.java:54)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:842)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:886)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6533)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
	at java.awt.Component.processEvent(Component.java:6298)
	at java.awt.Container.processEvent(Container.java:2237)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2295)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4889)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4526)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4467)
	at java.awt.Container.dispatchEventImpl(Container.java:2281)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[Don-vip]

No error when disabling assertions. I wonder if the check is useful...

[Don-vip]

Ticket #17070 has been marked as a duplicate of this ticket.

[GerdP]

There is an option to use another algorithm which always seems to work. One can use expert option utilsplugin2.replace-geometry.robustAssignment to always use it. Maybe we can change the code so that this method is used when the assertion would fail?

[GerdP]

Might be caused by usage of List.remove(Object)

 List<Node> nodePool = getUnimportantNodes(subjectWay); 
 ...
 nodePool.remove(n);

Have to check this tomorrow.