Modify ↓
Opened 8 years ago
Closed 7 years ago
#15696 closed defect (fixed)
DMSCoordinateFormat using ',' instead of '.' in German or Portuguese
Reported by: | michael2402 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 18.09 |
Component: | Core | Version: | |
Keywords: | Cc: |
Description
This makes the ICoordinateFormatTest
fail if the locale is set to German.
org.junit.ComparisonFailure: expected:<47°00'00[.]0"N> but was:<47°00'00[,]0"N> at org.junit.Assert.assertEquals(Assert.java:115) at org.junit.Assert.assertEquals(Assert.java:144) at org.openstreetmap.josm.data.coor.conversion.ICoordinateFormatTest.testFormatting(ICoordinateFormatTest.java:34) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.openstreetmap.josm.testutils.JOSMTestRules$TimeoutThread.run(JOSMTestRules.java:558)
Question is: Should we always format it in the localized way (fix test) or use the '.' separator in all locales?
Attachments (0)
Change History (7)
comment:2 by , 8 years ago
Milestone: | 17.12 → 18.01 |
---|
comment:3 by , 8 years ago
Milestone: | 18.01 |
---|
comment:4 by , 7 years ago
Summary: | DMSCoordinateFormat using ',' instead of '.' in German → DMSCoordinateFormat using ',' instead of '.' in German or Portuguese |
---|
Same problem with pt_BR, see #16688
comment:5 by , 7 years ago
Same problem with ExifReaderTest.testReadLatLon
junit.framework.AssertionFailedError: expected:<51°46'43[.]0"> but was:<51°46'43[,]0"> at org.openstreetmap.josm.tools.ExifReaderTest.testReadLatLon(ExifReaderTest.java:107)
comment:6 by , 7 years ago
Milestone: | → 18.09 |
---|
Note:
See TracTickets
for help on using tickets.
In
AbstractCoordinateFormat
we expect to always have a dot:So this looks like a bug.