Drop area=yes from closed highway=services|rest_area

[naoliv]

I guess that due to ​https://github.com/gravitystorm/openstreetmap-carto/issues/137 and ​https://github.com/openstreetmap/iD/issues/4194 we have 12320 highway=services|rest_area with an unnecessary area=yes ​https://overpass-turbo.eu/s/tKb

It seems safe to drop area=yes

data/validator/unnecessary.mapcss

@@ -32 +32 @@
   fixRemove: "{2.key}";
 }
 
+/* #15664 */
+area:closed[highway=rest_area][area?],
+area:closed[highway=services][area?] {
+  throwWarning: tr("{0} is unnecessary for {1}", "{2.key}", "{1.tag}");
+  group: tr("unnecessary tag");
+  fixRemove: "{2.key}";
+}
+
 *[emergency=permissive] {
   /* see #9458 - emergency=permissive makes no sense */
   throwWarning: tr("{0} makes no sense", "{0.tag");

[Don-vip]

Should the test be also extended to railway values listed there? ​https://github.com/openstreetmap/iD/commit/10659505e2a4d131cf01fe1a1cade4c170118afa#diff-a38515b4b0fcbf25755cd7345c9bbf78R155

[naoliv]

There are:
railway=roundhouse + area=yes has 3 objects
railway=station + area=yes has 3434
railway=traverser + area=yes has 63
railway=turntable + area=yes has 178
railway=wash + area=yes has 5

But it seems that the default renderer still needs area=yes for some cases.
For example, railway=station without area isn't rendered ​https://www.openstreetmap.org/way/233216247
While with area=yes it is: ​https://www.openstreetmap.org/way/332922836

[Klumbumbus]

Replying to naoliv:

For example, railway=station without area isn't rendered ​https://www.openstreetmap.org/way/233216247

This is rendered!?

[naoliv]

Replying to Klumbumbus:

Replying to naoliv:

For example, railway=station without area isn't rendered ​https://www.openstreetmap.org/way/233216247

This is rendered!?

Maybe it's now rendered because it was modified to include public_transport=station :-)

Some new railway=station examples
​https://www.openstreetmap.org/way/93768774
​https://www.openstreetmap.org/way/194746272
​https://www.openstreetmap.org/way/515564646
​https://www.openstreetmap.org/way/310235340

[Klumbumbus]

Hm strange, I thought the public_transport tags were not in the carto database at all.

[Klumbumbus]

In 13377/josm:

fix #15664 - warn about unnecessary area=yes at closed highway=services|rest_area