JOSM not respecting layers in display

[dieterdreist]

What is the expected result?

layer order in screen rendering respected (draw first lower layers)

What happens instead?

underlying way rendered above bridge

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-12-05 00:58:56 +0100 (Tue, 05 Dec 2017)
Build-Date:2017-12-05 02:33:31
Revision:13194
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13194 en) Mac OS X 10.13.1
OS Build number: Mac OS X 10.13.1 (17B1003)
Memory Usage: 1211 MB / 1820 MB (329 MB allocated, but free)
Java version: 1.8.0_144-b01, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 188875522 1920x1080, Display 458628992 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
+ ColorPlugin (1511895663)
+ Create_grid_of_ways (33856)
+ ImportImagePlugin (33563)
+ PicLayer (33822)
+ ShapeTools (1230)
+ apache-commons (33668)
+ buildings_tools (33735)
+ editgpx (33782)
+ ejml (32680)
+ fieldpapers (v0.4.3)
+ geochat (33796)
+ geojson (73)
+ geotools (33930)
+ imagery_offset_db (33774)
+ jts (32699)
+ log4j (32699)
+ mbtiles (a3e491d)
+ measurement (33760)
+ o5m (33566)
+ osmarender (33916)
+ pbf (33568)
+ photo_geotagging (33878)
+ reltoolbox (33708)
+ reverter (33865)
+ undelete (33835)
+ utilsplugin2 (33742)

Last errors/warnings:
- W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- W: Already here java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- W: Already here java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- W: Already here java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- W: Already here java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- W: Already here java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net

[Klumbumbus]

What's the object id?

[Don-vip]

Isn't it a regression from r13125 as well?

[Klumbumbus]

No, layer tags were never taken into account for the internal style until now. (I once (some years ago) tried to create a patch, but failed.)

[Don-vip]

Ah ok, my bad. Well you have learned a lot since ;)

[Klumbumbus]

Well, in mapcss it should be pretty simple like that: way[layer]::* {z-index: tag("layer");}
However the bigger problem is that we either need to free one of major-z-index, z-index or object-z-index to use for this or invent a fourth like layer-tag-z-index. Currently I think all the major-/z-/object-z-indexes are a bit confused in our style and it is hard to understand as a whole so it is hard to make any change without braking something.

[Don-vip]

ok, not so easy!

[Klumbumbus]

As a side effect r13125 "fixed" the same problem for waterway tunnels in most cases, see gif in ticket:15483#comment:5. Maybe this makes the not perfect bridge rendering more obvious.