Correlate with GPX - decimal separator bug

[StephaneP]

What steps will reproduce the problem?

1. Use Josm in French, with windows in french
2. Load some pictures and a gpx/nmea file
3. enter a decimal value for the time offset in the picture correlate with gpx window

What is the expected result?

You can correlate the pictures with the gpx

What happens instead?

decimal value for the time offset is refused
But it works if I switch Josm to english language

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-11-14 01:41:49 +0100 (Tue, 14 Nov 2017)
Build-Date:2017-11-14 02:40:51
Revision:13122
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13122 fr) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1709 (16299)
Memory Usage: 1021 MB / 5461 MB (642 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1200, \Display1 2560x1440
Maximum Screen Size: 2560x1440

Plugins:
+ DirectUpload (33182)
+ ImportImagePlugin (33563)
+ Mapillary (v1.5.8)
+ OpeningHoursEditor (33185)
+ PicLayer (33385)
+ SimplifyArea (33004)
+ apache-commons (33668)
+ apache-http (32699)
+ areaselector (1505420454)
+ austriaaddresshelper (1495805712)
+ auto_tools (1494971731)
+ buildings_tools (33735)
+ cadastre-fr (33706)
+ continuosDownload (64)
+ contourmerge (1032)
+ download_along (33710)
+ editgpx (33782)
+ ejml (32680)
+ geotools (33380)
+ jts (32699)
+ log4j (32699)
+ merge-overlap (33436)
+ opendata (33791)
+ osm-obj-info (1505407450)
+ photo_geotagging (33494)
+ photoadjust (33746)
+ reverter (33572)
+ tag2link (33382)
+ tageditor (33806)
+ turnlanes-tagging (254)
+ turnrestrictions (33780)
+ undelete (33480)
+ utilsplugin2 (33742)

Tagging presets:
+ E:\OsmIndoor\Dossiers Persos\Antoine\Train_Station-preset.xml
+ E:\OsmIndoor\200 gares\200gares-preset.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1

Last errors/warnings:
- W:  Connexion RATP: Could not get presets icon presets/underground.png
- E: Impossible de trouver l'image "presets/toll_station.png"
- W:  CAB way: Could not get presets icon presets/toll_station.png
- E: Impossible de trouver l'image "presets/bollard.png"
- W:  CAB node: Could not get presets icon presets/bollard.png
- E: Impossible de trouver l'image "presets/toilet.png"
- W: [NODE, CLOSEDWAY] Toilets: Could not get presets icon presets/toilet.png
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Avertissement: le scan du fichier 'site-svn.openstreetmap.org-_applications_editors_josm_plugins_opendata_modules.txt' pour le module d'information a échoué. Action ignorée.
- W: Avertissement: le scan du fichier 'fr.datagouvfr.jar' pour le module d'information a échoué. Action ignorée.

[Don-vip]

Missed in #14602

[Don-vip]

Not missed. Missed the fact our server produces the jar file on its own. The official jars do not contain the META-INF/services directory.

[Don-vip]

I have updated the makefile and pushed a small javadoc commit to release a new version in r13123. The jar seems correct now, can you please check?

[StephaneP]

Tested with r13123. It doesn't work. (same message : "Format attendu : number")

[bastiK]

Replying to Don-vip:

I have updated the makefile and pushed a small javadoc commit to release a new version in r13123. The jar seems correct now, can you please check?

It is not expected to work in Java 8, is it?

[Don-vip]

You're right, I forgot that too! Stephane: please test with Java 9, it should work.

[StephaneP]

JRE 9.0.1 and I still have the same problem.

[Don-vip]

Indeed, there's a problem I don't understand yet.

[Don-vip]

OK r13050 is just plain wrong. Double.parseDouble() only accept dot as decimal separator, and does not use at all the one configured in DecimalFormat like I thought. So the parsing of floating numbers is currently broken for all languages having something else than a dot as decimal separator (like in French).

[Don-vip]

In 13124/josm:

fix #15552 - fix parsing of decimal numbers

[StephaneP]

I confirm the bug is fixed with r13124

Thank you!

[Don-vip]

Ticket #15592 has been marked as a duplicate of this ticket.