[PATCH] building=yes is described as residential building

[mkoniecz]

What steps will reproduce the problem?

1. create way
2. tag building=yes

What is the expected result?

Not described as residential building

What happens instead?

described as residential building

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-10-30 23:58:23 +0100 (Mon, 30 Oct 2017)
Build-Date:2017-10-31 02:33:18
Revision:13064
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13064 en) Linux Ubuntu 16.04.3 LTS
Memory Usage: 934 MB / 934 MB (459 MB allocated, but free)
Java version: 1.8.0_151-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (33185)
+ buildings_tools (33735)
+ lakewalker (33712)
+ reverter (33572)
+ undelete (33480)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1
- ${HOME}/Documents/install_moje/josm_style_sidewalks/Styles_Sidewalks-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/HU-HighlightHikingTrailSigns&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1

Validator rules:
+ ${HOME}/Documents/install_moje/josm_validator/josm.validator.mapcss

Last errors/warnings:
- E: java.net.SocketException: Socket closed
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out

[naoliv]

Have the generic building=yes only at the Building preset.
Also roof

data/defaultpresets.xml

@@ -6811 +6811 @@
                   ru.href="http://wiki.openstreetmap.org/wiki/RU:Key:building"
                   uk.href="http://wiki.openstreetmap.org/wiki/Uk:Key:building" />
             <space />
-            <combo key="building" text="Building" values="yes,residential,apartments,house,hotel,hut,bungalow,dormitory,terrace,detached,farm,roof" default="residential" match="keyvalue!" values_context="building" values_searchable="true" />
+            <combo key="building" text="Building" values="residential,apartments,house,hotel,hut,bungalow,dormitory,terrace,detached,farm" default="residential" match="keyvalue!" values_context="building" values_searchable="true" />
             <optional>
                 <text key="name" text="Name" />
                 <combo key="building:levels" text="Levels" values="1,2,3,4,5,6,7,8,9,10,11" text_context="building" />

[Klumbumbus]

The value "yes" was added to the residential building preset in r9392 to link it in the Tags/Membership dialog on the right, so you can switch from the default value "yes" to an more precise value by clicking the link there. I agree this is not an optimal solution but I think it is better than if only the building preset is linked there and not the residential building preset too. I think with the current match implementation (TaggingPresets) there is no better solution possible.

(However we should remove roof from the residential building preset as this is not the default value.)

[Klumbumbus]

In 13185/josm:

see #15524 - remove roof from residential preset

[Klumbumbus]

fixed for "roof"
wontfix for "yes"