Modify ↓
Opened 7 years ago
Closed 7 years ago
#15505 closed enhancement (fixed)
Update com.drew.metadata sourcecode to current GitHub code
Reported by: | naoliv | Owned by: | Don-vip |
---|---|---|---|
Priority: | normal | Milestone: | 17.11 |
Component: | Core | Version: | |
Keywords: | Cc: |
Description
length
is always > 16
, so we don't need to test if it's == 1
:
-
src/com/drew/metadata/TagDescriptor.java
73 73 if (object.getClass().isArray()) { 74 74 final int length = Array.getLength(object); 75 75 if (length > 16) { 76 return String.format("[%d %s]", length, length == 1 ? "value" : "values");76 return String.format("[%d values]", length); 77 77 } 78 78 }
Attachments (0)
Change History (7)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Milestone: | → 17.11 |
---|
comment:3 by , 7 years ago
Hum... only now I am seeing that it's an external source.
I was trying to spot low hanging fruits in the code with IntelliJ.
comment:5 by , 7 years ago
Summary: | [PATCH] simplify test for long arrays in TagDescriptor.java → Update com.drew.metadata sourcecode to current GitHub code |
---|
comment:6 by , 7 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Note:
See TracTickets
for help on using tickets.
Did you find this yourself, or do you ask us to backport https://github.com/drewnoakes/metadata-extractor/commit/a101da7e051bc03d2f06ab69dd5c4c63e7597c9d#diff-5e6af2075900c3b1cc5713d461008f95 ?
It's better to simply update the whole source code :)