#1536 closed defect (fixed)
[PATCH] osmarender plugin does not create output
Reported by: | Owned by: | framm | |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Plugin | Version: | latest |
Keywords: | osmarender | Cc: |
Description
Just installed the osmarender plugin to JOSM 929 and entered the Firefox executable to settings. Selecting 'view>osmarender' spawns firefox but I receive an error message in firefox saying that 'C:\User\<...>\JOSM\plugins\osmarender\osmarendergenerated.xml' wasn't found. And in fact there is no file with that name.
Even dropping an osm file in that folder and renaming it to osmarendergenerated.xml creates exactly the same error.
I use Firefox 3.1 ('Minefield') and MS Vista. (Browser shouldn't be a problem as long as that xml file doesn't show up)
Attachments (1)
Change History (17)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
I ment "same" Problem...
don't know what to do, nobody seems to be interested in this problem.
I am using Java64Bit VM 1.6.07.
Greets
Gandalf
comment:4 by , 16 years ago
I had the same problem (JOSM V1004, FF 1.5.0.12, Linux Fedora Core 6, Java 1.6.0_03-b05).
From a first look at the source code, it looks like the plugin has problems separating File paths and file names. E.g. on Linux, instead of looking for a file ".../plugins/osmarendergenerated.xml" it should instead look for ".../plugins/osmarender/generated.xml" (i.e. in the osmarender subdirectory!).
When it's trying to create that generated.xml file, it wants to read osmarenderosm-map-features.xml, but should look for osmarender/osm-map-features.xml instead.
With several soft links (e.g. linking osmarender/osm-map-features.xml to osmarenderosm-map-features.xml) I was able to see a SVG graphic in the firefox window. This is of course only a quick hack, the plugin should be fixed to use File.separator, e.g. in method writeGenerated(): new FileReader( getPluginDir() + File.separator + "osm-map-features.xml").
I'm not a Java expert, but I might try to fix it some time later, if nobody else steps up...
by , 15 years ago
Attachment: | file-separator.patch added |
---|
patch to fix file locations (added File.separator)
follow-up: 7 comment:6 by , 15 years ago
With the uploaded file-separator.patch, the plugin now works for me on both Linux and Windows.
comment:7 by , 15 years ago
Replying to Purzel:
With the uploaded file-separator.patch, the plugin now works for me on both Linux and Windows.
Can you explain me, what i have to do with this file? I only have a osmarender.jar file. i can't find the osmarenderplugin.java anywhere, neither on my pc, nor in a svn repository.
comment:8 by , 15 years ago
Priority: | minor → major |
---|
Raising priority. This plugin (osmarender) is NOT USABLE without the fix. There are plenty of people on the mailing lists who have the same problem. The fix is simple, but I don't have the credentials to change it in SVN (as far as I know).
For osmarender this bug has "BLOCKER" priority, but I guess "blocker" in this bug DB is for the whole JOSM project, not for a single plugin, so I refrained from setting priority that high...
comment:9 by , 15 years ago
How can I use this Patch ?
I don't know where to copy it or what I have to do with this patch ?
Please help !
comment:10 by , 15 years ago
The patch is a source patch. You need to apply it to the source files of the plugin and then build it using the Java compiler.
As a service I've build the plugin and put it on http://frawe.bplaced.net/osmarender.jar
comment:11 by , 15 years ago
Thank you very much, but now I get another error.
Here it is in german:
Fehler während der XSLT-Transformation: Eine unbekannte XPath-Erweiterungsfunktion wurde aufgerufen.
And when I try to translate
Error while XSLT-transformation: an unknown XPATH-additional function was called.
What can I do ?
follow-up: 13 comment:12 by , 15 years ago
That message comes from Firefox but I don't know why. I'm using 3.0.4 here and don't get any errors, only warnings in the error console.
On the other hand that problem isn't particular to you, see http://www.mail-archive.com/talk-de@openstreetmap.org/msg23458.html or http://forum.openstreetmap.org/viewtopic.php?pid=10649 for example.
comment:14 by , 15 years ago
When I installed Firefox 3, the problem was gone.
But now I have a problem, because you need Firefox 2 to use the YWMS plugin!
comment:15 by , 15 years ago
Summary: | osmarender plugin does not create output → [PATCH] osmarender plugin does not create output |
---|
some Problem with XP64 (SP2) and Firefox 3.0.3