Modify

Opened 18 months ago

Closed 17 months ago

Last modified 17 months ago

#15357 closed enhancement (fixed)

add cemetery=grave and historic=tomb

Reported by: WlaKom Owned by: team
Priority: normal Milestone: 17.10
Component: Internal preset Version:
Keywords: historic tomb cemetery grave Cc: Klumbumbus

Description (last modified by Klumbumbus)

Add grave as node (cemetery=grave; historic=tomb) at maximum zoom.
Currently, many graves are mapped in cemeteries, but users do not see them.

Attachments (2)

tombcomp.png (1.5 KB) - added by Klumbumbus 18 months ago.
15.svg (4.9 KB) - added by Klumbumbus 18 months ago.

Download all attachments as: .zip

Change History (29)

comment:1 Changed 18 months ago by Don-vip

Component: CoreInternal preset

comment:2 Changed 18 months ago by Don-vip

Cc: Klumbumbus added
Milestone: 17.09

Tag is documented, used 4000+ times, worldwide, I'd say yes.

comment:3 Changed 18 months ago by Don-vip

Summary: cemetery=graveadd cemetery=grave

comment:4 Changed 18 months ago by Don-vip

Milestone: 17.0917.10

comment:5 Changed 18 months ago by Don-vip

We would need two presets (one for historic=tomb, one for cemetery=grave).

Found a grave icon:
https://raw.githubusercontent.com/osmandapp/OsmAnd-resources/master/rendering_styles/style-icons/drawable-hdpi/mx_tomb.png https://github.com/osmandapp/OsmAnd-resources/blob/master/icons/svg/tourist/tomb.svg

But nothing free for tomb (mainly used for tumulus, crypts, mausoleums, pyramids, etc.)

comment:6 Changed 18 months ago by Don-vip

Keywords: historic tomb cemetery added
Summary: add cemetery=graveadd cemetery=grave and historic=tomb

comment:7 Changed 18 months ago by Don-vip

historic=tomb is now used more than 10000 times in OSM database.

I'm a little bit surprised according to its definition and I wonder if people are not using this tag to map simple graves. "Tomb" may be a false friend in several languages. For example in French, a grave is a "tombe" and a tomb is a "tombeau".

@Klumbumbus: do you have a suggestion for an icon?

comment:8 Changed 18 months ago by WlaKom

Similarity of names, but different meanings are common on OSM.
But we are based on the British language.
As I wrote earlier, a very small black square would be completely sufficient. The rectangle would require the direction along the axis. The cross would not be appropriate for non-Christians.

Changed 18 months ago by Klumbumbus

Attachment: tombcomp.png added

comment:9 Changed 18 months ago by Klumbumbus

I tried to create an icon. The rightmost is my suggestion for historic=tomb (15.svg)



Last edited 18 months ago by Klumbumbus (previous) (diff)

Changed 18 months ago by Klumbumbus

Attachment: 15.svg added

comment:10 Changed 18 months ago by Klumbumbus

Also the wikipages need some clarification. E.g. the description of cemetery=grave is "To map a tomb."

comment:11 Changed 18 months ago by Klumbumbus

Description: modified (diff)

comment:13 in reply to:  9 Changed 18 months ago by Don-vip

Replying to Klumbumbus:


I love it!

comment:14 in reply to:  9 ; Changed 18 months ago by WlaKom

Replying to Klumbumbus:
Very nice.
But how do you want to show them in line with rows and columns?

comment:15 in reply to:  14 ; Changed 18 months ago by Klumbumbus

Replying to WlaKom:

But how do you want to show them in line with rows and columns?

I don't really understand what you mean. The icon will be displayed at the position of respective tagged nodes at the nodes position.

comment:16 in reply to:  15 Changed 18 months ago by WlaKom

Replying to Klumbumbus:

Replying to WlaKom:

But how do you want to show them in line with rows and columns?

I don't really understand what you mean. The icon will be displayed at the position of respective tagged nodes at the nodes position.

Vertical, not in the direction of the position of the graves, which can be 45 degrees from the vertical. Graves are usually in line, not always vertical.
See the graves in the attached link to the cemetery.
We have a similar problem with benches if they are not parallel to the adjacent path.

comment:17 Changed 18 months ago by Don-vip

There is no direction of whatever, graves will be rendered as icons at their node position.

comment:18 in reply to:  17 Changed 18 months ago by WlaKom

Replying to Don-vip:

There is no direction of whatever, graves will be rendered as icons at their node position.

Not exactly. I saw hundreds of graves mapped as rectangles.
According to Wiki, the grave can be mapped as a node or as an outline.

comment:19 Changed 18 months ago by Don-vip

Well in this case the geometry will be rendered like any other feature.

comment:20 Changed 18 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 12993/josm:

fix #15357 - add cemetery=grave and historic=tomb

comment:21 Changed 17 months ago by Klumbumbus

Resolution: fixed
Status: closedreopened

I think if both cemetery=grave and historic=tomb is tagged the icon for tomb should be prioritized in the mapview, as this is the more specialized and more important tag.

comment:22 Changed 17 months ago by Don-vip

Can you please fix it? This is the last remaining ticket now.

comment:23 Changed 17 months ago by Klumbumbus

I'm on it

comment:24 Changed 17 months ago by Don-vip

I think we can promote this version as the "Halloween edition" of JOSM and invite user to map cemeteries :D

comment:25 Changed 17 months ago by Klumbumbus

I just noticed that the grave icon is black within JOSM and therefore invisible on the default black background. I'll adjust it.

comment:26 Changed 17 months ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 13052/josm:

fix #15357 - prioritize tomb over grave icon, fix grave icon

comment:27 in reply to:  24 Changed 17 months ago by WlaKom

Replying to Don-vip:

I think we can promote this version as the "Halloween edition" of JOSM and invite user to map cemeteries :D

In Poland, everyone visits the graves of their loved ones from 1 to 2 November

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.