Use rpm return value instead of localized message

[jirislaby@…]

From src/org/openstreetmap/josm/tools/PlatformHookUnixoid.java:

    // rpm returns translated string "package %s is not installed\n", can't find a way to force english output
    // translations from https://github.com/rpm-software-management/rpm
    private static final String[] NOT_INSTALLED = {
            "not installed",          // en
            "no s'ha instal·lat",     // ca
            "尚未安裝",                // cmn
...

rpm respects locales:

$ rpm -q test
balíček test není nainstalován
$ LANG=en rpm -q test
package test is not installed
$ LANG=POSIX rpm -q test
package test is not installed

So just set the environment variable to POSIX (or to en) and you are done.

[anonymous]

Or even better, use the return value of rpm.

$ LANG=en rpm -q test
package test is not installed
$ echo $?
1
$ rpm -q rpm
rpm-4.13.0.1-5.2.x86_64
$ echo $?
0

[Don-vip]

WTH is this bug report, you mean? We cannot control the locale set by all JOSM users.

[Jiri Slaby <jirislaby@…>]

But you can control locale of rpm.

Or you can use rpm return value.

[Don-vip]

OK. But please avoid tickets with such titles...

[Jiri Slaby <jirislaby@…>]

It was so funny when I saw it, that I though the author cannot really mean it.

So FWIW:

import java.io.IOException;

class env {
        public static void main(String args[]) {
                try {
                        ProcessBuilder pb =
                                new ProcessBuilder().inheritIO().command(
                                        new String[] {"rpm", "-q", "test"});
                        pb.environment().put("LANG", "POSIX");
                        Process p = pb.start();

                } catch (IOException e) {
                        System.err.println(e);
                }
        }
}

[Jiri Slaby <jirislaby@…>]

oops

[Don-vip]

Well keep in mind we have a lot of bug reports to handle, and this kind of titles is not funny for us. Thanks for reporting it.

[Don-vip]

In 12830/josm:

fix #15297, fix #15298 - proper detection of java packages on rpm-based Linux systems

[Don-vip]

Not tested, can you please check tomorrow if everything's OK?